Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CORE_IAF_JRA55do datm datamode #219

Closed
dougiesquire opened this issue Aug 29, 2024 · 13 comments
Closed

Rename CORE_IAF_JRA55do datm datamode #219

dougiesquire opened this issue Aug 29, 2024 · 13 comments
Assignees

Comments

@dougiesquire
Copy link
Collaborator

We should probably rename the CORE_IAF_JRA55do datm datamode - see @aekiss's comment here

which is confusing, because CORE is a different dataset from JRA55do, and also the same stream names are also used for the RYF configs.

This will also require changes to all our configs to update the datamode in datm_in - e.g. here.

@dougiesquire
Copy link
Collaborator Author

This change has now been merged, but let's leave this issue open until we've released the changes and updated the configs

@aekiss
Copy link
Contributor

aekiss commented Sep 18, 2024

Can somebody build this version so we can complete ACCESS-NRI/access-om3-configs#123? I'm not sure how to go about it.

@aekiss
Copy link
Contributor

aekiss commented Sep 19, 2024

I built access-om3 in /scratch/v45/aek156/build/access-om3/Release using build.sh, but I don't know how to build it and put it in /g/data/ik11/spack/0.21.2/modules/access-om3/0.x.0/linux-rocky8-cascadelake (which is what I want for the config.yaml update in ACCESS-NRI/access-om3-configs#123) - is that documented somewhere?

@ezhilsabareesh8
Copy link
Contributor

@aekiss Even I built using build.sh, but I asked Micael for guidance on how to build it in /g/data/ik11/spack/0.21.2/modules/access-om3/0.x.0/linux-rocky8-cascadelake. I'm still awaiting his response.

@dougiesquire
Copy link
Collaborator Author

It's not really documented anywhere unfortunately, but hopefully this is the last time we do this with the ik11 spack environment. I can do a new development build later today.

@anton-seaice
Copy link
Contributor

There are some instructions for the cosima spack here:

https://github.com/COSIMA/spack-config/blob/0.21.2/README.md

I'm sure they need refinement, but its not totally undocumented :)

@aekiss
Copy link
Contributor

aekiss commented Sep 19, 2024

Thanks @anton-seaice, I've now added a link to that in the wiki https://github.com/COSIMA/access-om3/wiki/Building

@dougiesquire
Copy link
Collaborator Author

Sorry for the delay, but this is done now.

$ module use /g/data/ik11/spack/0.21.2/modules/access-om3/0.x.0/linux-rocky8-cascadelake
$ module load access-om3/96f91599f746b4866bbd3f05ee6eb192ba70d391_main

Configs will obviously need to be updated accordingly.

@aekiss
Copy link
Contributor

aekiss commented Sep 19, 2024

Awesome, thanks @dougiesquire! Nothing to apologise for - aren't you on leave?

@aekiss
Copy link
Contributor

aekiss commented Sep 19, 2024

Any objections if we do the config updates via ACCESS-NRI/access-om3-configs#123?
That issue needs to update datm.streams.xml, which is done via an updated generation script that uses the new datamode name, making these issues interdependent.

@anton-seaice
Copy link
Contributor

As long as its clear in the commits what is going on (and no squash merging) thats ok by me :)

@aekiss
Copy link
Contributor

aekiss commented Sep 19, 2024

I think we'll want to avoid squash merges as we'll need to do some detailed cherry-picking for the various configs.

aekiss added a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 20, 2024
aekiss added a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 20, 2024
anton-seaice pushed a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 25, 2024
anton-seaice pushed a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 25, 2024
anton-seaice pushed a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 25, 2024
anton-seaice pushed a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 25, 2024
anton-seaice pushed a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 25, 2024
anton-seaice pushed a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 26, 2024
anton-seaice pushed a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 26, 2024
anton-seaice pushed a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 26, 2024
anton-seaice pushed a commit to ACCESS-NRI/access-om3-wav-configs that referenced this issue Sep 26, 2024
anton-seaice pushed a commit to ACCESS-NRI/access-om3-wav-configs that referenced this issue Sep 30, 2024
anton-seaice pushed a commit to ACCESS-NRI/access-om3-wav-configs that referenced this issue Oct 1, 2024
anton-seaice pushed a commit to ACCESS-NRI/access-om3-wav-configs that referenced this issue Oct 3, 2024
@anton-seaice
Copy link
Contributor

Closed through access-om3-configs:

dev-1deg_ryf
ACCESS-NRI/access-om3-configs#123
dev-1deg_iaf
ACCESS-NRI/access-om3-configs#130
dev-1deg_ryf_wombatlite
ACCESS-NRI/access-om3-configs#125
dev-025deg_ryf

https://github.com/ACCESS-NRI/access-om3-configs/pull/126

access-om3-wav-configs:

dev-1deg_ryf
ACCESS-NRI/access-om3-wav-configs#52
dev-1deg_iaf ACCESS-NRI/access-om3-wav-configs#53

Noting there are other issues with runoff (e.g. #231)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants