Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom exception classes in command checks #349

Open
CarrotManMatt opened this issue Oct 15, 2024 · 1 comment
Open

Use custom exception classes in command checks #349

CarrotManMatt opened this issue Oct 15, 2024 · 1 comment
Assignees
@CarrotManMatt
Labels
high priority Needs focus/attention as soon as possible refactor Improvements to the codebase that do not directly affect users

Comments

@CarrotManMatt
Copy link
Member

As suggested by Py-cord's documentation custom exception classes should be raised when a command check fails, so that the command that failed can later be determined.
image

Once this has been completed, #348 can be reverted
@CarrotManMatt CarrotManMatt added refactor Improvements to the codebase that do not directly affect users high priority Needs focus/attention as soon as possible labels Oct 15, 2024
@CarrotManMatt CarrotManMatt self-assigned this Oct 15, 2024
@MattyTheHacker
Copy link
Member

Notably #348 also contained other dependency updates so won't be a straight revert but ye

@CarrotManMatt CarrotManMatt changed the title Use custom exception classes Use custom exception classes in command checks Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarrotManMatt CarrotManMatt

Labels
high priority Needs focus/attention as soon as possible refactor Improvements to the codebase that do not directly affect users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MattyTheHacker @CarrotManMatt