From c6b4e9f7564475371fefb91e81b3f6dd9ca746b9 Mon Sep 17 00:00:00 2001
From: Andrew Dickson <33495813+ajd299@users.noreply.github.com>
Date: Fri, 1 Mar 2024 12:17:31 -0500
Subject: [PATCH] KFSPTS-31154 CheckRecon Set Active Flag true (#1571)

---
 .../kuali/kfs/cr/batch/CheckReconciliationImportStep.java       | 1 +
 .../rsmart/kuali/kfs/cr/businessobject/CheckReconciliation.java | 2 +-
 .../kuali/kfs/cr/dataaccess/impl/CheckReconciliationDaoOjb.java | 1 +
 .../kuali/kfs/cr/batch/CheckReconciliationImportStepTest.java   | 1 +
 .../kuali/kfs/cr/batch/fixture/CheckReconciliationFixture.java  | 1 +
 .../cr/document/CheckReconciliationMaintainableImplTest.java    | 1 +
 6 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/main/java/com/rsmart/kuali/kfs/cr/batch/CheckReconciliationImportStep.java b/src/main/java/com/rsmart/kuali/kfs/cr/batch/CheckReconciliationImportStep.java
index 1ba8c28638..d56b5acc9a 100644
--- a/src/main/java/com/rsmart/kuali/kfs/cr/batch/CheckReconciliationImportStep.java
+++ b/src/main/java/com/rsmart/kuali/kfs/cr/batch/CheckReconciliationImportStep.java
@@ -893,6 +893,7 @@ private CheckReconciliation setCheckReconciliationAttributes(Map<Integer, String
         issueDate = dateParser.apply(issueDateRawValue);
         
         CheckReconciliation cr = new CheckReconciliation();
+        cr.setActive(true);
         cr.setAmount(amount);
         cr.setCheckDate(new java.sql.Date(issueDate.getTime()));
         cr.setCheckNumber(new KualiInteger(checkNumber));
diff --git a/src/main/java/com/rsmart/kuali/kfs/cr/businessobject/CheckReconciliation.java b/src/main/java/com/rsmart/kuali/kfs/cr/businessobject/CheckReconciliation.java
index b4ea28ff08..9db01e9bfe 100644
--- a/src/main/java/com/rsmart/kuali/kfs/cr/businessobject/CheckReconciliation.java
+++ b/src/main/java/com/rsmart/kuali/kfs/cr/businessobject/CheckReconciliation.java
@@ -61,7 +61,7 @@ public class CheckReconciliation extends PersistableBusinessObjectBase implement
     
     private Bank bank;
 
-    private boolean active;
+    private boolean active = true;
     
     /**
      * Constructs a CheckBase business object.
diff --git a/src/main/java/com/rsmart/kuali/kfs/cr/dataaccess/impl/CheckReconciliationDaoOjb.java b/src/main/java/com/rsmart/kuali/kfs/cr/dataaccess/impl/CheckReconciliationDaoOjb.java
index 4a154ad50c..4248333d84 100644
--- a/src/main/java/com/rsmart/kuali/kfs/cr/dataaccess/impl/CheckReconciliationDaoOjb.java
+++ b/src/main/java/com/rsmart/kuali/kfs/cr/dataaccess/impl/CheckReconciliationDaoOjb.java
@@ -117,6 +117,7 @@ public Collection<CheckReconciliation> getNewCheckReconciliations(Collection<Ban
             
             while(rs.next()) {
                 cr = new CheckReconciliation();
+                cr.setActive(true);
                 cr.setCheckNumber(new KualiInteger(rs.getInt(1)));
                 cr.setCheckDate(new java.sql.Date(rs.getDate(2).getTime()));  //This is last status change date.
                 cr.setAmount(new KualiDecimal(rs.getDouble(3)));
diff --git a/src/test/java/com/rsmart/kuali/kfs/cr/batch/CheckReconciliationImportStepTest.java b/src/test/java/com/rsmart/kuali/kfs/cr/batch/CheckReconciliationImportStepTest.java
index 30e647b178..47c44670f9 100644
--- a/src/test/java/com/rsmart/kuali/kfs/cr/batch/CheckReconciliationImportStepTest.java
+++ b/src/test/java/com/rsmart/kuali/kfs/cr/batch/CheckReconciliationImportStepTest.java
@@ -551,6 +551,7 @@ private void assertCheckReconciliationImportHadExpectedUpdates(
             assertEquals(checkReconFixture.newCheckStatus, checkRecon.getStatus(), "Wrong check status");
             assertEquals(checkReconFixture.getParsedStatusChangeDate(), checkRecon.getStatusChangeDate(),
                     "Wrong status change date");
+            assertTrue(checkRecon.isActive());
         }
     }
 
diff --git a/src/test/java/com/rsmart/kuali/kfs/cr/batch/fixture/CheckReconciliationFixture.java b/src/test/java/com/rsmart/kuali/kfs/cr/batch/fixture/CheckReconciliationFixture.java
index 6eb180d7a8..9c80172c34 100644
--- a/src/test/java/com/rsmart/kuali/kfs/cr/batch/fixture/CheckReconciliationFixture.java
+++ b/src/test/java/com/rsmart/kuali/kfs/cr/batch/fixture/CheckReconciliationFixture.java
@@ -100,6 +100,7 @@ public CheckReconciliation toCheckReconciliationUsingCurrentStatus() {
     private CheckReconciliation toCheckReconciliation() {
         CheckReconciliation checkReconciliation = new CheckReconciliation();
         checkReconciliation.setId(ordinal());
+        checkReconciliation.setActive(true);
         checkReconciliation.setBankCode(bankCode);
         checkReconciliation.setBankAccountNumber(getExpectedBankAccountNumber());
         checkReconciliation.setCheckNumber(checkNumber);
diff --git a/src/test/java/com/rsmart/kuali/kfs/cr/document/CheckReconciliationMaintainableImplTest.java b/src/test/java/com/rsmart/kuali/kfs/cr/document/CheckReconciliationMaintainableImplTest.java
index e98e1d8f66..d5399d18b9 100644
--- a/src/test/java/com/rsmart/kuali/kfs/cr/document/CheckReconciliationMaintainableImplTest.java
+++ b/src/test/java/com/rsmart/kuali/kfs/cr/document/CheckReconciliationMaintainableImplTest.java
@@ -68,6 +68,7 @@ private MaintenanceDocument prepareMaintenanceDocument(String checkNumberString,
         document.setDocumentHeader(dh);
 
         CheckReconciliation newCr = new CheckReconciliation();
+        newCr.setActive(true);
         KualiInteger checkNumber = new KualiInteger(checkNumberString);
         newCr.setCheckNumber(checkNumber);