Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused linear layers in pointer-generators #303

Open
kylebgorman opened this issue Feb 6, 2025 · 0 comments
Open

Unused linear layers in pointer-generators #303

kylebgorman opened this issue Feb 6, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@kylebgorman
Copy link
Contributor

The GRU pointer-generator implementation includes a linear layer called merge_h, which presumably is intended to be used to "merge" hidden state from the source and features encoders; the LSTM one also includes an additional layer called merge_c, presumably for the cell state. However, these are not actually ever used, and as far as I can tell, they never were (I looked back a bit) and should either be removed or perhaps wired in.

@Adamits, I have assigned this to you because I'm frankly afraid to touch this module much, but maybe you'd be comfortable addressing this.

@kylebgorman kylebgorman added the bug Something isn't working label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants