From db9bac1f7d64cb0d6ba6dfa439681805d5852d92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Velarde?= Date: Wed, 4 Jan 2023 10:07:11 +0100 Subject: [PATCH 1/3] Little tweak for better default customVersion value for GoogleMap --- packages/react-basemaps/src/basemaps/GoogleMap.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-basemaps/src/basemaps/GoogleMap.js b/packages/react-basemaps/src/basemaps/GoogleMap.js index 7be0fd8c3..1bc5237e1 100644 --- a/packages/react-basemaps/src/basemaps/GoogleMap.js +++ b/packages/react-basemaps/src/basemaps/GoogleMap.js @@ -15,7 +15,7 @@ import { debounce } from '@carto/react-core'; * @param { function } props.onViewStateChange - (Optional) onViewStateChange handler * @param { string } props.apiKey - Google Maps API Key * @param { string } props.mapId - Google Maps custom mapId - * @param { string } props.customVersion - (Optional) Google Maps custom version, that will be specified at url level. Eg: if customVersion === 'beta' it will use internally like https://maps.google.com/maps/api/js?v=beta + * @param { string } props.customVersion - (Optional) Google Maps custom version, that will be specified at url level. Eg: if customVersion === 'beta' it will use internally like this: https://maps.google.com/maps/api/js?v=beta * @returns { JSX.Element } - Data returned from the SQL query execution */ export function GoogleMap(props) { @@ -28,7 +28,7 @@ export function GoogleMap(props) { onViewStateChange, apiKey, mapId, - customVersion = null + customVersion = '' } = props; // based on https://publiuslogic.com/blog/google-maps+react-hooks/ const containerRef = useRef(); From bce7ed5fef816629f4f63035ede468fdda157239 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Velarde?= Date: Wed, 4 Jan 2023 10:26:08 +0100 Subject: [PATCH 2/3] Always ensure full refresh in BarWidgetUI --- packages/react-ui/src/widgets/BarWidgetUI.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-ui/src/widgets/BarWidgetUI.js b/packages/react-ui/src/widgets/BarWidgetUI.js index e89b42e4c..2404ebcc3 100644 --- a/packages/react-ui/src/widgets/BarWidgetUI.js +++ b/packages/react-ui/src/widgets/BarWidgetUI.js @@ -317,6 +317,7 @@ function BarWidgetUI(props) { From 0632de262cda5cf45f199736b4f54d9d72418d0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Velarde?= Date: Wed, 4 Jan 2023 10:29:31 +0100 Subject: [PATCH 3/3] Prepare changelog entry --- CHANGELOG.md | 1 + packages/react-basemaps/src/basemaps/GoogleMap.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 923340f5a..5d80aac18 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ## Not released - Allow to use custom version explictly in GoogleMap (not 'beta' by default now) [#550](https://github.com/CartoDB/carto-react/pull/550) +- Fix lack of refresh in BarWidgetUI when modyfing yAxisData dinamically [#558](https://github.com/CartoDB/carto-react/pull/558) ## 1.5 diff --git a/packages/react-basemaps/src/basemaps/GoogleMap.js b/packages/react-basemaps/src/basemaps/GoogleMap.js index 1bc5237e1..f98e2f50c 100644 --- a/packages/react-basemaps/src/basemaps/GoogleMap.js +++ b/packages/react-basemaps/src/basemaps/GoogleMap.js @@ -15,7 +15,7 @@ import { debounce } from '@carto/react-core'; * @param { function } props.onViewStateChange - (Optional) onViewStateChange handler * @param { string } props.apiKey - Google Maps API Key * @param { string } props.mapId - Google Maps custom mapId - * @param { string } props.customVersion - (Optional) Google Maps custom version, that will be specified at url level. Eg: if customVersion === 'beta' it will use internally like this: https://maps.google.com/maps/api/js?v=beta + * @param { string } props.customVersion - (Optional) Google Maps custom version, that will be specified at url level. Eg: if customVersion === 'beta' it will use internally this: https://maps.google.com/maps/api/js?v=beta * @returns { JSX.Element } - Data returned from the SQL query execution */ export function GoogleMap(props) {