Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrongly instantiated Map doesn't fail #1489

Open
josemazo opened this issue Jan 16, 2020 · 3 comments
Open

Wrongly instantiated Map doesn't fail #1489

josemazo opened this issue Jan 16, 2020 · 3 comments
Assignees
Labels

Comments

@josemazo
Copy link
Contributor

josemazo commented Jan 16, 2020

I found this bug when I tried to create a map with two layers, ignoring that the first parameter, layers should be a list, and I passed the second layer as the basemap: Map(Layer(gdf), Layer(iso_gdf)). The result is that it doesn't say anything, not even an error, and the widget is empyt.

image

@Jesus89
Copy link
Member

Jesus89 commented Jan 16, 2020

You need to provide a list of Layers to the Map.

Map([Layer, Layer])

However, we should add some checks to validate the input parameters.

@Jesus89 Jesus89 self-assigned this Jan 16, 2020
@josemazo
Copy link
Contributor Author

Yes, taking a not so quick look to the docs I got it, hehe.

@Jesus89 Jesus89 removed the triage label Jun 17, 2020
@Jesus89
Copy link
Member

Jesus89 commented Jul 20, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants