From 259183dbdf4ff202b61245f403f80508e29ecbbe Mon Sep 17 00:00:00 2001
From: Leonhard Brunner <leonhard.brunner@student.tugraz.at>
Date: Mon, 16 Aug 2021 22:01:46 +0200
Subject: [PATCH 1/2] ATLDEV-323 Add check if the time format is correct

ATLDEV-323 remove debugger
---
 src/main/resources/js/timesheet/table.js | 40 ++++++++++++++++++++++--
 1 file changed, 37 insertions(+), 3 deletions(-)

diff --git a/src/main/resources/js/timesheet/table.js b/src/main/resources/js/timesheet/table.js
index 84636d9..a4e2553 100644
--- a/src/main/resources/js/timesheet/table.js
+++ b/src/main/resources/js/timesheet/table.js
@@ -8,6 +8,8 @@ var savingError;
 var ppFlag;
 var dateRangeFlag;
 var dateFlag;
+var timeStartFlag;
+var timeEndFlag;
 var descrFlag;
 var pauseFlag;
 
@@ -405,6 +407,14 @@ function prepareForm(entry, timesheetData, isModified) {
         form.saveButton.prop('disabled', false);
     });
 
+    form.beginTimeField.change(function () {
+        form.saveButton.prop('disabled', false);
+    });
+
+    form.endTimeField.change(function () {
+        form.saveButton.prop('disabled', false);
+    });
+
     row.find('input.time.start, input.time.end')
         .timepicker({
             showDuration: false,
@@ -1120,17 +1130,41 @@ function submit(timesheetData, saveOptions, form, existingEntryID,
     if ((date == "") || (!isValidDate(validDateFormat))) {
         date = new Date().toJSON().slice(0, 10);
     }
-
+    
     var beginTime = form.beginTimeField.timepicker('getTime');
 
     if (beginTime === null) {
-        beginTime = new Date();
+        if (timeStartFlag)
+            timeStartFlag.close();
+        timeStartFlag = AJS.flag({
+            type: 'warning',
+            title: 'Invalid start time format',
+            body: 'The start time should be a valid time.',
+            close: 'auto'
+        });
+
+        form.beginTimeField.css({
+            "border-color": "red"
+        });
+        return;
     }
 
     var endTime = form.endTimeField.timepicker('getTime');
 
     if (endTime === null) {
-        endTime = new Date();
+        if (timeStartFlag)
+            timeStartFlag.close();
+        timeStartFlag = AJS.flag({
+            type: 'warning',
+            title: 'Invalid end time format',
+            body: 'The end time should be a valid time.',
+            close: 'auto'
+        });
+
+        form.endTimeField.css({
+            "border-color": "red"
+        });
+        return;
     }
 
     date = date.replace(/-/g, "/");

From a5fe8cfa3803afbdb34127cca15090657191c9db Mon Sep 17 00:00:00 2001
From: Leonhard Brunner <leonhard.brunner@student.tugraz.at>
Date: Tue, 24 Aug 2021 17:03:00 +0200
Subject: [PATCH 2/2] ATLDEV-323 requested changes

---
 src/main/resources/js/timesheet/table.js | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/main/resources/js/timesheet/table.js b/src/main/resources/js/timesheet/table.js
index a4e2553..35603de 100644
--- a/src/main/resources/js/timesheet/table.js
+++ b/src/main/resources/js/timesheet/table.js
@@ -1148,6 +1148,11 @@ function submit(timesheetData, saveOptions, form, existingEntryID,
         });
         return;
     }
+    else {
+        form.beginTimeField.css({
+            "border-color": "#DCDCDC"
+        });
+    }
 
     var endTime = form.endTimeField.timepicker('getTime');
 
@@ -1166,6 +1171,11 @@ function submit(timesheetData, saveOptions, form, existingEntryID,
         });
         return;
     }
+    else {
+        form.endTimeField.css({
+            "border-color": "#DCDCDC"
+        });
+    }
 
     date = date.replace(/-/g, "/");
     var pauseTime = form.pauseTimeField.timepicker('getTime');