Skip to content

Lab 3: Review Notes / Potential Issues #2

@Cd16d

Description

@Cd16d
  • JSTK: RGB LED write is not atomic;

  • Mute: (IF s_axis_tvalid = '1' AND m_axis_tready = '1' THEN) → incorrect AXI check. Should check s_axis_tready instead. Current logic waits for m_axis_tready to assert valid. Would be correct if s_axis_tready were directly connected to m_axis_tready.

  • Volume Controller: Waits for m_axis_tready to assert valid (IF s_axis_tvalid = '1' AND m_axis_tready = '1' THEN).

  • Balance: Same AXI issue as above.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions