From 62b4b476f494a0fcbdf8bcf3d2d49fbb205238d5 Mon Sep 17 00:00:00 2001 From: A K M Rezaul Karim Date: Sun, 17 May 2020 18:32:58 +0600 Subject: [PATCH] BE #4 fix 404 on delete method --- routes/article.js | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/routes/article.js b/routes/article.js index 79ce66c..b6c1569 100644 --- a/routes/article.js +++ b/routes/article.js @@ -150,9 +150,17 @@ router.route('/:articleId') if (mongoose.Types.ObjectId.isValid(req.params.articleId)) { Article.findByIdAndRemove(req.params.articleId) .then((resp) => { - res.statusCode = 200; - res.setHeader('Content-Type', 'application/json'); - res.json(resp); + if(null===resp){ + var err = new Error('Article ' + req.params.articleId + ' not found'); + err.status = 404; + return next(err); + } + else{ + res.statusCode = 200; + res.setHeader('Content-Type', 'application/json'); + res.json(resp); + } + }, (err) => next(err)) .catch((err) => next(err)); }