Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two-node model iteration #147

Open
FedericoTartarini opened this issue Nov 22, 2024 · 0 comments
Open

two-node model iteration #147

FedericoTartarini opened this issue Nov 22, 2024 · 0 comments
Milestone

Comments

@FedericoTartarini
Copy link
Collaborator

FedericoTartarini commented Nov 22, 2024

Describe the bug

  1. The code is not efficient since the main loops runs for 60 times:
    1. this is unnecessary in most conditions since the results converge before the 60 iterations, however,
    2. for some inputs, 60 iterations are not sufficient and terminate the code routine before the code has converged.

To Reproduce

Example 1

two_nodes(tdb = 45,tr = 45,v = 1.1,rh = 20,clo = 0.2,met = 3)

image

Example 2

(tdb=25, tr=25, v=0.6, rh=50, met=1, clo=.5)

image

Expected behavior

We should stop the iteration only when the output converges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant