-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From Call Data with proxy.proxy should have option to NOT override. #613
Comments
Hi, this is originally a feature, because many users have a tendency to copy/paste a call with proxy, although Multix takes care of this. It feels a little like a feature creep, but I think I'll let you remove this override with a click. |
gm! Thank you. It definitely makes sense to prevent the foot gun. Maybe there can be a check to see if the call data is using the proxy in multix (and hence should be overwritten), or if the proxy is a separate proxy (and should not be overwritten) |
oh, this is a very good idea. I'll see how feasible it is, I like the elegance of the solution :) |
I've made a PR and you'll be able to play with the preview URL soon. |
here's the preview @peterwht please let me know if this is what you've been expecting: https://51fb3293.multix.pages.dev/ |
Thanks for getting this added @Tbaut. I checked the preview URL, and this is exactly what we needed. Can confirm it shows up in the wallet preview as well: And then when using our proxy registered in Multix, it will properly overwrite the call and just show the underlying call (in this case, balances.transferKeepAlive). |
Amazing, thanks for the reply. It's merged and will be live in a couple minutes ;) |
The setup is Multisig -> Pure Proxy 1 -> Pure Proxy 2 .
Multix doesn't support creating calls for Pure Proxy 2 (would be a great feature, but it diverges from the current issue :) ). This requires manually creating the
proxy.proxy
call on p.js. The call data is then copied and provided to Multix for Pure Proxy 1.From Call Data
is selected, with the encoded call data includingproxy.proxy
. Multix gives a warning saying "Multix will override the proxy.proxy call with the proxy you have selected".This makes it so the entire transaction now has to be created via p.js because we need:
The text was updated successfully, but these errors were encountered: