Skip to content

Add Safe and Finalized test variants for EthTraceReplayBlockTransactions #6654

@coderabbitai

Description

@coderabbitai

Description

Add test coverage for Predefined::Safe and Predefined::Finalized variants for both EthTraceReplayBlockTransactions and EthTraceReplayBlockTransactionsV2 RPC methods.

Details

Both handlers now support the TipsetResolver and accept Predefined::Safe and Predefined::Finalized tags via BlockNumberOrHash, matching the pattern used by EthTraceBlock and EthTraceBlockV2. The test coverage should reflect this capability.

Location

File: src/tool/subcommands/api_cmd/api_compare_tests.rs (around lines 2142-2149)

Task

For each of the two RPC handlers (EthTraceReplayBlockTransactions and EthTraceReplayBlockTransactionsV2):

  • Add RpcTest::identity requests that pass BlockNumberOrHash constructed with Predefined::Safe
  • Add RpcTest::identity requests that pass BlockNumberOrHash constructed with Predefined::Finalized
  • Mirror the existing epoch-based calls pattern
  • Ensure the suite covers TipsetResolver-supported tags the same way EthTraceBlock/EthTraceBlockV2 do

References

Metadata

Metadata

Assignees

Labels

RPCrequires calibnet RPC checks to run on CI

Type

No type

Projects

Status

In progress

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions