Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gossamer persists default config and CLI flags in config file #4293

Open
haikoschol opened this issue Oct 30, 2024 · 0 comments
Open

Gossamer persists default config and CLI flags in config file #4293

haikoschol opened this issue Oct 30, 2024 · 0 comments
Labels
P-high this should be addressed ASAP. S-cli issue related to Gossamer CLI. T-bug this issue covers unexpected and/or wrong behaviour.

Comments

@haikoschol
Copy link
Contributor

Describe the bug

Gossamer writes its current configuration to a config file without being asked to do so.

Expected Behavior

When the node is run with a certain CLI flag, the value of that flag is applied to the configuration of the running process.

When the node is run again, without passing this CLI flag, the configuration value is taken from the config file or its default value.

Current Behavior

When the node is run with a certain CLI flag, the value of that flag is applied to the configuration of the running process and the config file is overwritten with the same config.

When the node is run again, without passing this CLI flag, the previously passed value is read from the config file and applied.

Possible Solution

Don't write a configuration file.

To Reproduce

Steps to reproduce the behaviour:

  1. run gossamer and terminate the process
  2. run grep peers config/config.toml in the gossamer data directory and note the value of min peers
  3. run gossamer --min-peers N with an N that is not the number from step 2 and terminate the process
  4. run grep peers config/config.toml in the gossamer data directory and find the value of min peers to be the one passed in step 3
@haikoschol haikoschol added T-bug this issue covers unexpected and/or wrong behaviour. S-cli issue related to Gossamer CLI. P-high this should be addressed ASAP. labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high this should be addressed ASAP. S-cli issue related to Gossamer CLI. T-bug this issue covers unexpected and/or wrong behaviour.
Projects
None yet
Development

No branches or pull requests

1 participant