Replace * value with other more bash friendly value

[nflaig]

Problem description

* is not very friendly to use in bash, it has to be quoted or else it will not be handled as a string but an operator instead, i.e. it will list all files of the directory.

There are currently a few CLI flags that accept * as a value

• --rest.namespace
• --rest.cors
• --keymanager.cors

See Command Line Reference for an overview of all non-hidden flags.

Solution description

Replace * value with other more bash friendly value, for example the word all.

It has to be considered what value to use for cors as * has a special meaning in this context.

Additional context

No response

[clionachee]

Hi, may I know specifically which file or all the files? Is this issue still needing to be resolved?

[nflaig]

Hey, there are multiple cases but likely just wanna change this for --rest.namespace (see related PR #2809), and make sure it's backward compatible, i.e. * should still be handled if passed by the user.

lodestar/packages/cli/src/options/beaconNodeOptions/api.ts

Line 4 in c7c9941

const enabledAll = "*";

It is probably also the only place where we would wanna change this, as for .cors CLI flags, the * has special meaning, and we can't change it to something like "all" there as it might be confusing.

[clionachee]

Thanks. I suppose if it's ok, I'll fork the Repo, make the changes in that file, replace the value & commit changes if no problem?

[nflaig]

Sure, go ahead, you can open a PR here after you are done with your changes. Happy to review :)

[clionachee]

Created PR #6459 thanks w/ love.

[philknows]

#7011 target

[nflaig]

011 target

we should add this in a backward compatible way

[eenagy]

Can we have proper quoting instead of replacing it? ex: --rest.namespace '*' and so on.

[nflaig]

Can we have proper quoting instead of replacing it? ex: --rest.namespace '*' and so on.

Yes, you have to quote it otherwise it won't work, that's why we wanna replace it with a more bash friendly value.