Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miss balances ssz cache in state transition #6520

Closed
twoeths opened this issue Mar 8, 2024 · 0 comments · Fixed by #6557
Closed

Miss balances ssz cache in state transition #6520

twoeths opened this issue Mar 8, 2024 · 0 comments · Fixed by #6557
Assignees
Labels
meta-bug Issues that identify a bug and require a fix.

Comments

@twoeths
Copy link
Contributor

twoeths commented Mar 8, 2024

Describe the bug

In every epoch transition, we create balances tree from a list of number[] and the resulting ViewDU does not contain any cached nodes https://github.com/ChainSafe/lodestar/blob/36f50cf08337e70b0f8078949a23162256ec03a2/packages/state-transition/src/epoch/processRewardsAndPenalties.ts#L36C40-L36C48

If we have balances cached nodes we can:

this issue is shown in lodestar nodes:

Screenshot 2024-03-08 at 13 22 05

Expected behavior

Retain balances ssz cache after we create balances

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

unstable

@twoeths twoeths added the meta-bug Issues that identify a bug and require a fix. label Mar 8, 2024
@twoeths twoeths self-assigned this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant