Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnose why findModifiedValidators benchmark failing after upgrading #7380

Closed
nazarhussain opened this issue Jan 20, 2025 · 0 comments · Fixed by #7415
Closed

Diagnose why findModifiedValidators benchmark failing after upgrading #7380

nazarhussain opened this issue Jan 20, 2025 · 0 comments · Fixed by #7415
Labels
meta-bug Issues that identify a bug and require a fix. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.

Comments

@nazarhussain
Copy link
Contributor

Describe the bug

The benchmark for findModifiedValidators is failing after upgraded to the @chainsafe/benchmark.

Expected behavior

All other benchmarks seems to pass, so why this benchmark should also pass.

Steps to reproduce

Run all benchmarks with yarn benchmark

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

[unstable]
@nazarhussain nazarhussain added the meta-bug Issues that identify a bug and require a fix. label Jan 20, 2025
@nflaig nflaig mentioned this issue Jan 21, 2025
Merged
@philknows philknows added the scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. label Jan 24, 2025
@nflaig nflaig mentioned this issue Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta-bug Issues that identify a bug and require a fix. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: revert skipping one benchmark ChainSafe/lodestar
2 participants
@nazarhussain @philknows