Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating point support #53

Open
CharlyCst opened this issue Apr 23, 2024 · 4 comments
Open

Floating point support #53

CharlyCst opened this issue Apr 23, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@CharlyCst
Copy link
Owner

For now we just ignore floating point registers, but we should ensure they are not leaking from the S-mode payload to the firmware.

I don't know much about the RISC-V implementation yet, but for other architectures there is a dirty bit that says if the floating point registers were accessed. If RISC-V has a similar concept, we should save the floating point registers before transitioning from the payload to the firmware, or from the payload to the firmware.

@CharlyCst CharlyCst added the enhancement New feature or request label Apr 23, 2024
@francois141
Copy link
Collaborator

@CharlyCst According to the specification: "The FS[1:0] and VS[1:0] WARL fields and the XS[1:0] read-only field are used to reduce the cost of context save and restore by setting and tracking the current state of the floating-point unit and any other user-mode extensions respectively."

Capture d’écran 2024-06-22 à 20 11 14

@francois141
Copy link
Collaborator

@CharlyCst Any oppositions if I grab this feature this week?

@CharlyCst
Copy link
Owner Author

As discussed we should look into that when we dig into policy modules.

@francois141
Copy link
Collaborator

@CharlyCst I link this issue to my PR for the protect Payload policy as we also tackle this problem at the same time.

@francois141 francois141 linked a pull request Sep 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants