Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Preview Critical Hit in token settings #29

Open
Yosoy-Ed opened this issue Mar 27, 2024 · 2 comments
Open

[Feature] Preview Critical Hit in token settings #29

Yosoy-Ed opened this issue Mar 27, 2024 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@Yosoy-Ed
Copy link

Is your feature request related to a problem? Please describe.

Previous update made nice changes to the cricital hit options in token settings. The new offset settings works but the user need to know many details of the image or guess by try an error waiting for a critical hit test.

Describe the solution you'd like

Any of two options could help:

A button to preview the animation inside the token setting.
An image inside the token setting showing the image area that will be shown with an update image button.

Describe alternatives you've considered
Lowering a token AC and test by try and error until getting the desired effect.

Additional context
None.

@Yosoy-Ed Yosoy-Ed added the enhancement New feature or request label Mar 27, 2024
@ChasarooniZ
Copy link
Owner

that'll have to be a later thing as there's no way to add that with current implementation of settings menu, will require rework of settings menu

@ChasarooniZ ChasarooniZ self-assigned this Mar 27, 2024
@ChasarooniZ ChasarooniZ added the dependencies Pull requests that update a dependency file label Mar 27, 2024
@Yosoy-Ed
Copy link
Author

that'll have to be a later thing as there's no way to add that with current implementation of settings menu, will require rework of settings menu

I understand.

I was jus reviewing your code and created a dirty workaround in the meanwhile for anyone interested.

It is a helper module creating another tab where the image can be tested to get the desired numbers, then input in the real one. It shows the animation for the current user only.

pf2e-rpg-numbers-testimg.zip

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants