Skip to content
This repository was archived by the owner on Sep 7, 2024. It is now read-only.

Support clues and boss killcount #3

Closed
AdamKBeck opened this issue Jan 4, 2020 · 6 comments
Closed

Support clues and boss killcount #3

AdamKBeck opened this issue Jan 4, 2020 · 6 comments

Comments

@AdamKBeck
Copy link
Contributor

There's been more categories on the hiscores. Any plans to update this wrapper?

@Chasesc
Copy link
Owner

Chasesc commented Jan 4, 2020

Hi Adam, I have added support in the latest commit.

Hiscores objects now have self.bosses and self.minigames with this data:

image

There are still a few bosses that are missing. Comparing the api response with the hiscores page could be done, but I got too lazy to do them all lol.

These instances are labeled as const.UNUSED_OR_UNKNOWN and are not included in the mappings.

@Chasesc Chasesc closed this as completed Jan 4, 2020
@AdamKBeck
Copy link
Contributor Author

Thanks for the quick turnaround. Other than the missing bosses, do you have any other features that need to be added?

@Chasesc
Copy link
Owner

Chasesc commented Jan 5, 2020

As far as I know, there is no official items API. We currently get the list of all items in the game from items_osrs.json. This file is a few years old now, so new items are not included. It would be nice if we had a better way to update this file, possibly automatically. I haven't done much research in this area.

In addition, if https://oldschool.runescape.wiki/ has some API, it would be nice to integrate into this repo. This could help with #2

If you have any additional ideas, feel free to open a PR or comment them here.

@AdamKBeck
Copy link
Contributor Author

AdamKBeck commented Jan 5, 2020

From the runescape wiki discord:

we don't do anything special with GE prices other than the median price that Jagex reports. you could use the osbuddy API for that
you can get a list of ALL items from the game cache, or a lot of other places

https://discord.gg/runescapewiki

@AdamKBeck
Copy link
Contributor Author

For twisted league I wrote a quick script to get the maximum total xp to see if there were any hidden people on the hiscores that haven't maxed yet. I wanted to make more crawlers to see momentum within the leagues to predict the final points people will end at.

I'm not sure if this is a separate project, or if you think it could be part of a PR for this project.

@Chasesc
Copy link
Owner

Chasesc commented Jan 5, 2020

For twisted league I wrote a quick script to get the maximum total xp to see if there were any hidden people on the hiscores that haven't maxed yet. I wanted to make more crawlers to see momentum within the leagues to predict the final points people will end at.

I'm not sure if this is a separate project, or if you think it could be part of a PR for this project.

Does it add any new functionality to the API? If so, those could be merged in.

If it is simple enough to follow quickly, it could be useful to put it in an examples directory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants