-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown commands send a message instead of failing #5675
Comments
Mentioned in https://twitch.uservoice.com/forums/310213-developers/suggestions/48972260-improve-error-messages-for-send-chat-message & https://discord.com/channels/504015559252377601/504015559252377605/1296195692838125578 but probably deserves its own github issue at https://github.com/twitchdev/issues/issues |
The behaviour did change between versions, atleast in twitch chat, it tells me "Unrecognized command" and the message is not sent, whilst in nightly chatterino, the message gets sent. I believe it should probably mimic similar behaviour, since you can have your own chatterino commands, I'd assume you would not think that it would just send the message. ... that is extremely unsafe, especially if you want to send a whisper or block someone and you mistype it. I believe chatterino should keep a list of possible commands and prompt you just in case you actually want to try sending an unknown command (e.g. before it is supported by this list), instead of just sending it straight away.
This mentions that the command is dropped, but in my observation, the message is NOT dropped, rather just sent without the command name. As a side note: |
We are likely to revert the Chat Send Protocol before it actually makes it into a new version |
Just wanted to mention that when typing without a message, Chatterino gives the error I assume it's related to the above and therefore would be fixed with the rollback - however would it not be worth checking to see if it's a command within Chatterino before sending as an irc command? |
Checklist
Describe your issue
Sending an unknown command sends a message instead
![{35881F79-D4C6-4237-8C66-DD92AB2795DE}](https://private-user-images.githubusercontent.com/1310440/379931880-c225b7d0-0adf-4a16-a67a-43f54a4f3609.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNDUwODgsIm5iZiI6MTczOTE0NDc4OCwicGF0aCI6Ii8xMzEwNDQwLzM3OTkzMTg4MC1jMjI1YjdkMC0wYWRmLTRhMTYtYTY3YS00M2Y1NGE0ZjM2MDkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMjM0NjI4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDRhODA2MmZlNTg3NDZiZThmY2JlNmU3NzBjNDYzYTYzNWRkODg2ZjQzMTUwNDBhMzU0NDM5YmU3NWNlNTNmNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.5elt5QykTWWBOJIVs_YIEGTa8o4fS7kQMUtns82jBuM)
does not happen with stable, happens with nightly
this should fail instead of sending a message, if you mistype your command (e.g. block/ban) then instead you send a message
Screenshots
No response
OS and Chatterino Version
Chatterino Nightly 2.5.1 (commit f66bc37) built on 2024-10-24 with Qt 6.7.1, MSVC 194134123, Crashpad Running on Windows 11 Version 24H2, kernel: 10.0.26120
The text was updated successfully, but these errors were encountered: