Add helper #7
Closed
Add helper #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmmarslender
requested changes
May 2, 2024
Comment on lines
+11
to
+12
| // GetTeamMemList obtains a list of teammembers | ||
| func GetTeamMemList(githubClient *github.Client, internalTeam string) (map[string]bool, error) { |
There was a problem hiding this comment.
Suggested change
| // GetTeamMemList obtains a list of teammembers | |
| func GetTeamMemList(githubClient *github.Client, internalTeam string) (map[string]bool, error) { | |
| // GetTeamMemberList obtains a list of teammembers | |
| func GetTeamMemberList(githubClient *github.Client, internalTeam string) (map[string]bool, error) { |
More clear to just use full names. No penalties for a slightly longer function name here
| }, | ||
| owner := parts[0] | ||
| repo := parts[1] | ||
| teamMembers, _ := github2.GetTeamMemList(githubClient, internalTeam) |
There was a problem hiding this comment.
This should not be inside of any loops - put it first thing in this function out of the loop. The team member list doesn't change based on what repo we're lookign at, and by doing it in the loop, we're rebuilding this list over and over for no gain (and a cost of a bunch of extra API calls and time)
| break | ||
| } | ||
| if lowestNumber <= fullRepo.MinimumNumber { | ||
| break |
There was a problem hiding this comment.
In this case, I think we just need to continue instead of break so that we can look at the other PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.