Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up type dispatcher in DoocsPVFactory #22

Open
phako opened this issue Apr 11, 2019 · 2 comments
Open

Clean-up type dispatcher in DoocsPVFactory #22

phako opened this issue Apr 11, 2019 · 2 comments
Labels
enhancement

Comments

@phako
Copy link
Member

phako commented Apr 11, 2019

Follow-up from #21. I am sure this can be done more elegant than like that:

388390a#diff-7439f3aea805a4897fe19e563955d0efR213
@phako
Copy link
Member Author

phako commented May 16, 2019

The even more elegant approach would be to make getNumberOfSamples() getNumberOfChannels() virtual in TransferElement and add final overrides in NDRegisterAccessor to de-virtualize the call for getting back the original non-indirect call.

@phako
Copy link
Member Author

phako commented May 16, 2019

Depends on ChimeraTK/DeviceAccess#66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phako @mhier