From 59ba7f3b7453dd3ec4538b147c677c9f79169d5b Mon Sep 17 00:00:00 2001
From: Chocobozzz <me@florianbigard.com>
Date: Thu, 26 Sep 2024 16:42:39 +0200
Subject: [PATCH] Remove form role on forms

---
 .../edit-custom-config/edit-custom-config.component.html      | 2 +-
 .../+admin/overview/users/user-edit/user-edit.component.html  | 2 +-
 .../overview/users/user-edit/user-password.component.html     | 2 +-
 .../plugin-show-installed.component.html                      | 2 +-
 client/src/app/+login/login.component.html                    | 2 +-
 .../video-channel-edit/video-channel-edit.component.html      | 2 +-
 .../my-account-change-email.component.html                    | 2 +-
 .../my-account-change-password.component.html                 | 2 +-
 .../my-account-email-preferences.component.html               | 2 +-
 .../my-account-profile/my-account-profile.component.html      | 2 +-
 .../my-account-two-factor.component.html                      | 4 ++--
 .../video-channel-sync-edit.component.html                    | 2 +-
 .../my-video-playlists/my-video-playlist-edit.component.html  | 2 +-
 client/src/app/+reset-password/reset-password.component.html  | 2 +-
 client/src/app/+search/search-filters.component.html          | 2 +-
 .../+register/steps/register-step-channel.component.html      | 2 +-
 .../+register/steps/register-step-terms.component.html        | 2 +-
 .../+signup/+register/steps/register-step-user.component.html | 2 +-
 .../verify-account-ask-send-email.component.html              | 2 +-
 .../app/+video-studio/edit/video-studio-edit.component.html   | 2 +-
 .../user-interface-settings.component.html                    | 2 +-
 .../shared-user-settings/user-video-settings.component.html   | 2 +-
 22 files changed, 23 insertions(+), 23 deletions(-)

diff --git a/client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.html b/client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.html
index 03cfa532596..f2e704ba222 100644
--- a/client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.html
+++ b/client/src/app/+admin/config/edit-custom-config/edit-custom-config.component.html
@@ -4,7 +4,7 @@ <h1 class="visually-hidden" i18n>Configuration</h1>
   Updating instance configuration from the web interface is disabled by the system administrator.
 </my-alert>
 
-<form role="form" [formGroup]="form">
+<form [formGroup]="form">
 
   <div ngbNav #nav="ngbNav" [activeId]="activeNav" (activeIdChange)="onNavChange($event)" class="nav-tabs">
 
diff --git a/client/src/app/+admin/overview/users/user-edit/user-edit.component.html b/client/src/app/+admin/overview/users/user-edit/user-edit.component.html
index d9b1fb00f22..90d3cb2d08e 100644
--- a/client/src/app/+admin/overview/users/user-edit/user-edit.component.html
+++ b/client/src/app/+admin/overview/users/user-edit/user-edit.component.html
@@ -85,7 +85,7 @@ <h2 class="visually-hidden">EDIT USER {{ user.username }}</h2>
 
   <div class="content-col">
     <div class="row">
-      <form class="col" role="form" (ngSubmit)="formValidated()" [formGroup]="form">
+      <form class="col" (ngSubmit)="formValidated()" [formGroup]="form">
         <div class="form-group" *ngIf="isCreation()">
           <label i18n for="username">Username</label>
           <input
diff --git a/client/src/app/+admin/overview/users/user-edit/user-password.component.html b/client/src/app/+admin/overview/users/user-edit/user-password.component.html
index ca6400f04a8..dfe186e1beb 100644
--- a/client/src/app/+admin/overview/users/user-edit/user-password.component.html
+++ b/client/src/app/+admin/overview/users/user-edit/user-password.component.html
@@ -1,4 +1,4 @@
-<form role="form" (ngSubmit)="formValidated()" [formGroup]="form">
+<form (ngSubmit)="formValidated()" [formGroup]="form">
 
   <div class="input-group">
     <input id="password"
diff --git a/client/src/app/+admin/plugins/plugin-show-installed/plugin-show-installed.component.html b/client/src/app/+admin/plugins/plugin-show-installed/plugin-show-installed.component.html
index dbc52109274..c778d5ce87c 100644
--- a/client/src/app/+admin/plugins/plugin-show-installed/plugin-show-installed.component.html
+++ b/client/src/app/+admin/plugins/plugin-show-installed/plugin-show-installed.component.html
@@ -5,7 +5,7 @@ <h2>
     {{ plugin.name }}
   </h2>
 
-  <form *ngIf="hasRegisteredSettings()" role="form" (ngSubmit)="formValidated()" [formGroup]="form">
+  <form *ngIf="hasRegisteredSettings()" (ngSubmit)="formValidated()" [formGroup]="form">
     <div class="form-group" *ngFor="let setting of registeredSettings" [id]="getWrapperId(setting)">
       <my-dynamic-form-field [hidden]="isSettingHidden(setting)" [form]="form" [setting]="setting" [formErrors]="formErrors"></my-dynamic-form-field>
     </div>
diff --git a/client/src/app/+login/login.component.html b/client/src/app/+login/login.component.html
index e1cb403412f..19cbdccb380 100644
--- a/client/src/app/+login/login.component.html
+++ b/client/src/app/+login/login.component.html
@@ -48,7 +48,7 @@ <h5 class="alert-heading" i18n>
     <div class="wrapper">
       <div class="login-form-and-externals">
 
-        <form class="w-100 m-0" myPluginSelector pluginSelectorId="login-form" role="form" (ngSubmit)="login()" [formGroup]="form">
+        <form class="w-100 m-0" myPluginSelector pluginSelectorId="login-form" (ngSubmit)="login()" [formGroup]="form">
           <ng-container *ngIf="!otpStep">
             <div class="form-group">
               <div>
diff --git a/client/src/app/+manage/video-channel-edit/video-channel-edit.component.html b/client/src/app/+manage/video-channel-edit/video-channel-edit.component.html
index 031513c53da..529a2b8a25b 100644
--- a/client/src/app/+manage/video-channel-edit/video-channel-edit.component.html
+++ b/client/src/app/+manage/video-channel-edit/video-channel-edit.component.html
@@ -1,7 +1,7 @@
 <my-alert *ngIf="error" type="danger">{{ error }}</my-alert>
 
 <div class="margin-content pt-4">
-  <form role="form" (ngSubmit)="formValidated()" [formGroup]="form">
+  <form (ngSubmit)="formValidated()" [formGroup]="form">
 
     <div class="pt-two-cols"> <!-- channel grid -->
       <div class="title-col">
diff --git a/client/src/app/+my-account/my-account-settings/my-account-change-email/my-account-change-email.component.html b/client/src/app/+my-account/my-account-settings/my-account-change-email/my-account-change-email.component.html
index 35d6bb10de3..082f24d02f8 100644
--- a/client/src/app/+my-account/my-account-settings/my-account-change-email/my-account-change-email.component.html
+++ b/client/src/app/+my-account/my-account-settings/my-account-change-email/my-account-change-email.component.html
@@ -5,7 +5,7 @@
   <strong>{{ user.pendingEmail }}</strong> is awaiting email verification
 </div>
 
-<form role="form" class="change-email" (ngSubmit)="changeEmail()" [formGroup]="form">
+<form class="change-email" (ngSubmit)="changeEmail()" [formGroup]="form">
 
   <div class="form-group">
     <label i18n for="new-email">Change your email</label>
diff --git a/client/src/app/+my-account/my-account-settings/my-account-change-password/my-account-change-password.component.html b/client/src/app/+my-account/my-account-settings/my-account-change-password/my-account-change-password.component.html
index eded6b55928..0f292899051 100644
--- a/client/src/app/+my-account/my-account-settings/my-account-change-password/my-account-change-password.component.html
+++ b/client/src/app/+my-account/my-account-settings/my-account-change-password/my-account-change-password.component.html
@@ -1,6 +1,6 @@
 <my-alert *ngIf="error" type="danger">{{ error }}</my-alert>
 
-<form role="form" (ngSubmit)="changePassword()" [formGroup]="form">
+<form (ngSubmit)="changePassword()" [formGroup]="form">
 
   <label i18n for="current-password">Change password</label>
   <my-input-text
diff --git a/client/src/app/+my-account/my-account-settings/my-account-email-preferences/my-account-email-preferences.component.html b/client/src/app/+my-account/my-account-settings/my-account-email-preferences/my-account-email-preferences.component.html
index b54a907bec9..68419ea04af 100644
--- a/client/src/app/+my-account/my-account-settings/my-account-email-preferences/my-account-email-preferences.component.html
+++ b/client/src/app/+my-account/my-account-settings/my-account-email-preferences/my-account-email-preferences.component.html
@@ -1,4 +1,4 @@
-<form role="form" (ngSubmit)="updateEmailPublic()" [formGroup]="form">
+<form (ngSubmit)="updateEmailPublic()" [formGroup]="form">
 
   <div class="form-group">
     <my-peertube-checkbox
diff --git a/client/src/app/+my-account/my-account-settings/my-account-profile/my-account-profile.component.html b/client/src/app/+my-account/my-account-settings/my-account-profile/my-account-profile.component.html
index f8803be6b7f..1a42ebb840d 100644
--- a/client/src/app/+my-account/my-account-settings/my-account-profile/my-account-profile.component.html
+++ b/client/src/app/+my-account/my-account-settings/my-account-profile/my-account-profile.component.html
@@ -1,6 +1,6 @@
 <my-alert *ngIf="error" type="danger">{{ error }}</my-alert>
 
-<form role="form" (ngSubmit)="updateMyProfile()" [formGroup]="form">
+<form (ngSubmit)="updateMyProfile()" [formGroup]="form">
 
   <div class="form-group">
     <label i18n for="username">Username</label>
diff --git a/client/src/app/+my-account/my-account-settings/my-account-two-factor/my-account-two-factor.component.html b/client/src/app/+my-account/my-account-settings/my-account-two-factor/my-account-two-factor.component.html
index 16c344e3bc6..7260916b679 100644
--- a/client/src/app/+my-account/my-account-settings/my-account-two-factor/my-account-two-factor.component.html
+++ b/client/src/app/+my-account/my-account-settings/my-account-two-factor/my-account-two-factor.component.html
@@ -9,7 +9,7 @@ <h1>
 
 <div class="root" *ngIf="twoFactorAlreadyEnabled === false">
   <ng-container *ngIf="step === 'request'">
-    <form role="form" (ngSubmit)="requestTwoFactor()" [formGroup]="formPassword">
+    <form (ngSubmit)="requestTwoFactor()" [formGroup]="formPassword">
 
       <label i18n for="current-password">Your password</label>
       <div class="form-group-description" i18n>Confirm your password to enable two factor authentication</div>
@@ -37,7 +37,7 @@ <h1>
 
     <div class="secret-plain-text">{{ twoFactorSecret }}</div>
 
-    <form class="mt-3" role="form" (ngSubmit)="confirmTwoFactor()" [formGroup]="formOTP">
+    <form class="mt-3" (ngSubmit)="confirmTwoFactor()" [formGroup]="formOTP">
 
       <label i18n for="otp-token">Two-factor code</label>
       <div class="form-group-description" i18n>Enter the code generated by your authenticator app to confirm</div>
diff --git a/client/src/app/+my-library/my-video-channel-syncs/video-channel-sync-edit/video-channel-sync-edit.component.html b/client/src/app/+my-library/my-video-channel-syncs/video-channel-sync-edit/video-channel-sync-edit.component.html
index 6b4282cfa53..1684edef778 100644
--- a/client/src/app/+my-library/my-video-channel-syncs/video-channel-sync-edit/video-channel-sync-edit.component.html
+++ b/client/src/app/+my-library/my-video-channel-syncs/video-channel-sync-edit/video-channel-sync-edit.component.html
@@ -7,7 +7,7 @@ <h2 i18n>NEW SYNCHRONIZATION</h2>
   </div>
 
   <div class="content-col">
-    <form role="form" (ngSubmit)="formValidated()" [formGroup]="form">
+    <form (ngSubmit)="formValidated()" [formGroup]="form">
 
       <div class="form-group">
         <label i18n for="externalChannelUrl">Remote channel URL</label>
diff --git a/client/src/app/+my-library/my-video-playlists/my-video-playlist-edit.component.html b/client/src/app/+my-library/my-video-playlists/my-video-playlist-edit.component.html
index 36a984403a6..ada4f34c68f 100644
--- a/client/src/app/+my-library/my-video-playlists/my-video-playlist-edit.component.html
+++ b/client/src/app/+my-library/my-video-playlists/my-video-playlist-edit.component.html
@@ -30,7 +30,7 @@ <h2 class="visually-hidden" i18n>UPDATE PLAYLIST</h2>
   </div>
 
   <div class="content-col">
-    <form role="form" (ngSubmit)="formValidated()" [formGroup]="form">
+    <form (ngSubmit)="formValidated()" [formGroup]="form">
 
       <div class="form-group">
         <label for="thumbnailfile" i18n>Playlist thumbnail</label>
diff --git a/client/src/app/+reset-password/reset-password.component.html b/client/src/app/+reset-password/reset-password.component.html
index fa53e7526be..04c99092939 100644
--- a/client/src/app/+reset-password/reset-password.component.html
+++ b/client/src/app/+reset-password/reset-password.component.html
@@ -1,7 +1,7 @@
 <div class="margin-content">
   <h1 i18n class="title-page">Reset my password</h1>
 
-  <form role="form" (ngSubmit)="resetPassword()" [formGroup]="form">
+  <form (ngSubmit)="resetPassword()" [formGroup]="form">
     <div class="form-group">
       <label i18n for="password">Password</label>
 
diff --git a/client/src/app/+search/search-filters.component.html b/client/src/app/+search/search-filters.component.html
index 1a6e75f0f12..c743ac57dba 100644
--- a/client/src/app/+search/search-filters.component.html
+++ b/client/src/app/+search/search-filters.component.html
@@ -1,4 +1,4 @@
-<form role="form" (ngSubmit)="formUpdated()">
+<form (ngSubmit)="formUpdated()">
 
   <div class="row">
     <div class="col-lg-4 col-md-6 col-xs-12">
diff --git a/client/src/app/+signup/+register/steps/register-step-channel.component.html b/client/src/app/+signup/+register/steps/register-step-channel.component.html
index 15a9e614af7..70e54d61e0f 100644
--- a/client/src/app/+signup/+register/steps/register-step-channel.component.html
+++ b/client/src/app/+signup/+register/steps/register-step-channel.component.html
@@ -13,7 +13,7 @@
   </p>
 </div>
 
-<form role="form" [formGroup]="form">
+<form [formGroup]="form">
 
   <div class="row">
 
diff --git a/client/src/app/+signup/+register/steps/register-step-terms.component.html b/client/src/app/+signup/+register/steps/register-step-terms.component.html
index bd63252a5a1..1a862f97786 100644
--- a/client/src/app/+signup/+register/steps/register-step-terms.component.html
+++ b/client/src/app/+signup/+register/steps/register-step-terms.component.html
@@ -1,4 +1,4 @@
-<form role="form" [formGroup]="form">
+<form [formGroup]="form">
 
   <div *ngIf="requiresApproval" class="form-group">
     <label i18n for="registrationReason">Why do you want to join {{ instanceName }}?</label>
diff --git a/client/src/app/+signup/+register/steps/register-step-user.component.html b/client/src/app/+signup/+register/steps/register-step-user.component.html
index f9ace47e753..11811af8279 100644
--- a/client/src/app/+signup/+register/steps/register-step-user.component.html
+++ b/client/src/app/+signup/+register/steps/register-step-user.component.html
@@ -2,7 +2,7 @@
   Video uploads are disabled on this instance, hence your account won't be able to upload videos.
 </my-alert>
 
-<form role="form" [formGroup]="form">
+<form [formGroup]="form">
   <div class="row">
 
     <div class="col-md-12 col-xl-6 form-group">
diff --git a/client/src/app/+signup/+verify-account/verify-account-ask-send-email/verify-account-ask-send-email.component.html b/client/src/app/+signup/+verify-account/verify-account-ask-send-email/verify-account-ask-send-email.component.html
index e3664845d49..7038468f6e7 100644
--- a/client/src/app/+signup/+verify-account/verify-account-ask-send-email/verify-account-ask-send-email.component.html
+++ b/client/src/app/+signup/+verify-account/verify-account-ask-send-email/verify-account-ask-send-email.component.html
@@ -1,7 +1,7 @@
 <div class="margin-content">
   <h1 i18n class="title-page">Request email for account verification</h1>
 
-  <form *ngIf="requiresEmailVerification; else emailVerificationNotRequired" role="form" (ngSubmit)="askSendVerifyEmail()" [formGroup]="form">
+  <form *ngIf="requiresEmailVerification; else emailVerificationNotRequired" (ngSubmit)="askSendVerifyEmail()" [formGroup]="form">
     <div class="form-group">
       <label i18n for="verify-email-email">Email</label>
 
diff --git a/client/src/app/+video-studio/edit/video-studio-edit.component.html b/client/src/app/+video-studio/edit/video-studio-edit.component.html
index a534f14708b..9c2cb1920bf 100644
--- a/client/src/app/+video-studio/edit/video-studio-edit.component.html
+++ b/client/src/app/+video-studio/edit/video-studio-edit.component.html
@@ -2,7 +2,7 @@
   <h1 class="title-page" i18n>Studio for {{ video.name }}</h1>
 
   <div class="grid-container">
-    <form role="form" [formGroup]="form">
+    <form [formGroup]="form">
 
       <div class="section cut" formGroupName="cut">
         <h2 i18n>CUT VIDEO</h2>
diff --git a/client/src/app/shared/shared-user-settings/user-interface-settings.component.html b/client/src/app/shared/shared-user-settings/user-interface-settings.component.html
index a1e02d89e16..e6847aabd57 100644
--- a/client/src/app/shared/shared-user-settings/user-interface-settings.component.html
+++ b/client/src/app/shared/shared-user-settings/user-interface-settings.component.html
@@ -1,4 +1,4 @@
-<form role="form" (ngSubmit)="updateInterfaceSettings()" [formGroup]="form">
+<form (ngSubmit)="updateInterfaceSettings()" [formGroup]="form">
 
   <div class="form-group">
     <label i18n for="theme">Theme</label>
diff --git a/client/src/app/shared/shared-user-settings/user-video-settings.component.html b/client/src/app/shared/shared-user-settings/user-video-settings.component.html
index 879f12583a3..b3f4e2db08f 100644
--- a/client/src/app/shared/shared-user-settings/user-video-settings.component.html
+++ b/client/src/app/shared/shared-user-settings/user-video-settings.component.html
@@ -1,4 +1,4 @@
-<form role="form" (ngSubmit)="updateDetails()" [formGroup]="form">
+<form (ngSubmit)="updateDetails()" [formGroup]="form">
   <div class="form-group">
     <div class="anchor" id="video-sensitive-content-policy"></div> <!-- video-sensitive-content-policy anchor -->
     <label i18n for="nsfwPolicy">Default policy on videos containing sensitive content</label>