Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use regex to allow many subdomains in the CORS allowed origins #78

Open
llunaCreixent opened this issue Apr 3, 2023 · 8 comments · May be fixed by #77
Open

Use regex to allow many subdomains in the CORS allowed origins #78

llunaCreixent opened this issue Apr 3, 2023 · 8 comments · May be fixed by #77
Assignees
@JacqueGM

Comments

@llunaCreixent
Copy link
Member

llunaCreixent commented Apr 3, 2023 •
edited
Loading

It needs to be added for the relayer.
@llunaCreixent
Copy link
Member Author

For the django app it seems we need to use another var: CORS_ALLOWED_ORIGIN_REGEXES

@llunaCreixent
Copy link
Member Author

Please add your planning poker estimate with Zenhub @juanenrisley

@llunaCreixent llunaCreixent self-assigned this Apr 3, 2023
@louilinn
Copy link

louilinn commented Apr 3, 2023 •
edited
Loading

We want to include:
"< anything >-circles-garden.netlify.app/"
also maybe all our own subdomains *.circles.garden

@juanenrisley
Copy link

@louilinn and I were able to change the netlify PR preview domains so we will just need to add *.circles.garden to CORS

@louilinn
Copy link

Yes ignore the netlify.app :)

@llunaCreixent llunaCreixent transferred this issue from CirclesUBI/circles-iac Apr 24, 2023
@llunaCreixent
Copy link
Member Author

Hey team! Please add your planning poker estimate with Zenhub @JacqueGM @juanenrisley

@llunaCreixent llunaCreixent linked a pull request Apr 24, 2023 that will close this issue
Draft
2 tasks
@llunaCreixent
Copy link
Member Author

Duplicated #76

@llunaCreixent llunaCreixent mentioned this issue Apr 24, 2023
Closed
@louilinn
Copy link

louilinn commented May 2, 2023

Deprioritized, doing staging env first.
It was more time consuming than expected. Work is paused.
We will still need it for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacqueGM JacqueGM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable hosts requests CirclesUBI/safe-relay-service
4 participants
@louilinn @juanenrisley @llunaCreixent @JacqueGM