Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamav-milter not available in DEB and RPM packages #1343

Open
maxadamo opened this issue Aug 19, 2024 · 1 comment
Open

clamav-milter not available in DEB and RPM packages #1343

maxadamo opened this issue Aug 19, 2024 · 1 comment

Comments

@maxadamo
Copy link

maxadamo commented Aug 19, 2024

Describe the bug

clamav-milter executable is not part of the RPM and DEB packages.

How to reproduce the problem

The output of either rpm -qpl clamav-1.4.0.linux.x86_64.rpm | grep milter or dpkg-deb -c clamav-1.4.0.linux.x86_64.deb | grep -i milter includes the man pages for clamav-milter, but the executable is missing:

/usr/local/share/man/man5/clamav-milter.conf.5
/usr/local/share/man/man8/clamav-milter.8

however, if I compile clamav myself, the executable is available.

I am guessing that you are only forgetting to include the executable in the package, because my compilation does nothing special. This is how I compile clamav:

cmake .. && \
cmake --build . && \
ctest && \
cmake --build . --target install

I am not sure how you create the packages, however, clamav-milter is mentioned in this file:
https://github.com/Cisco-Talos/clamav/blob/main/.github/workflows/clang-format.yml#L28

p.s.: this problem is present on all the latest versions: 1.4.x, 1.3.x, 1.0.x. I haven't tried the versions 0.x

@micahsnyder
Copy link
Contributor

This is a known/documented shortcoming for the official DEB and RPM packages.
https://docs.clamav.net/manual/Installing.html#linux-deb-rpm

It would be nice to add clamav-milter. The official DEB and RPM packages have all the dependencies statically linked so that they do not conflict with system packages, or depend on other packages. For clamav-milter, we'd need to build libmilter.a which comes from Sendmail. Very doable, we just need to put in a little work.

If anyone wants to help, we could use a recipe to build libmilter.a with as small of a build as possible in https://github.com/Cisco-Talos/clamav-mussels-cookbook/tree/master/recipes. You would only need to define the recipe for Linux under "host-static".

If that's done, then add libmilter as a dependency under Linux for https://github.com/Cisco-Talos/clamav-mussels-cookbook/blob/master/collections/clamav_deps-1.2.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants