Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the OSAL timer interface #21

Open
silabs-ThibautC opened this issue Jun 10, 2024 · 1 comment
Open

Rework the OSAL timer interface #21

silabs-ThibautC opened this issue Jun 10, 2024 · 1 comment

Comments

@silabs-ThibautC
Copy link
Collaborator

The OSAL API currently exposes a trickle timer API. All the logic specific to the tickle timers is generic and does not need to be in the abstraction layer. The current implementation will lead to code duplications and will force future developers to understand what's a trickle timer and how it works.
I suggest moving that logic out of the OSAL and exposing a generic timer API.

  1. define and implement a new osal_start_timer(duration, handler)
  2. move the tickle logic out of osal_linux.c and osal_freertos.c
@paduffy
Copy link
Collaborator

paduffy commented Jun 10, 2024

Agreed. I've pointed this out several times in the past.

@silabs-ThibautC silabs-ThibautC changed the title Rework the OLAL timer interface Rework the OSAL timer interface Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants