Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the tag to empty a string "" configures a tag with value 12345 #115

Open
jgomezve opened this issue Dec 1, 2022 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@jgomezve
Copy link

jgomezve commented Dec 1, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

  • 1.3.5.

DCNM version

  • V 12.1.1e

Affected Resource(s)

  • dcnm_network

Terraform Configuration Files

resource "dcnm_network" "first" {
  fabric_name  = "MyFabrc"
  name         = "MyNetwok"
  network_id   = "1234"
  display_name = "MyNetwok"
  vrf_name     = "MyVRF"
  tag          = ""
  deploy       = false
}

Debug Output

Panic Output

Expected Behavior

Routing Tag in NDFC should not be set to the default value (12345)

Actual Behavior

The value of the Routing Tag field should be empty but it configures the default value
image

Steps to Reproduce

  1. terraform apply

Important Factoids

References

@jgomezve jgomezve changed the title Setting the tag to empty string configures a tag with value 12345 Setting the tag to empty a string "" configures a tag with value 12345 Dec 2, 2022
@dsx1123
Copy link

dsx1123 commented Dec 14, 2022

@jgomezve the current SDK can't distinguish the difference between the empty string and non-provided parameter, we default the value to 12345 for the route tag as it is the default value provided in the default template.
the new framework of terraform provider seems to have a way to distinguish it, but it will be heavy lifting if we change to use it.

@jgomezve
Copy link
Author

@dsx1123 is there any way to set the Tag to an empty string "" ?

@dsx1123
Copy link

dsx1123 commented Dec 14, 2022

@jgomezve currently, there is no way, if we change the default value to "", it will break the backward compatibility, this tag is usually used for route filtering, will setting it to a dummy string be a workaround for you?

@jgomezve
Copy link
Author

I dont want to have the tag set on the SVI IP address.

interface Vlan2300
  vrf member vrf_tier2_lb_inside
  no ip redirects
  ip address 192.168.0.1/24 tag 12345
  fabric forwarding mode anycast-gateway
  no shutdown

I guess a dummy tag won't cause any problem but still it's something customers want to avoid

@dsx1123 dsx1123 added the enhancement New feature or request label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants