Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HERE pull token_expired error #1073

Open
gabrielwol opened this issue Sep 16, 2024 · 1 comment · May be fixed by #1074
Open

HERE pull token_expired error #1073

gabrielwol opened this issue Sep 16, 2024 · 1 comment · May be fixed by #1074
Assignees
@gabrielwol
Labels
bug here

Comments

@gabrielwol
Copy link
Collaborator

When pull_here and pull_here_path task get_download_link runs for more than an hour (example: DAG run 2024-09-13, 17:00:00 EDT), the token for the pull expires and subsequent retries on this task fail immediately with token_expired error. We could fail immediately in this case or retry from beginning of DAG.
@gabrielwol gabrielwol self-assigned this Sep 17, 2024
@radumas
Copy link
Member

radumas commented Sep 17, 2024

Duplicate of #204

I should have added more info in that issue :|

gabrielwol added a commit that referenced this issue Sep 17, 2024
@gabrielwol
#1073 remove unused imports
d941bda
gabrielwol added a commit that referenced this issue Sep 17, 2024
@gabrielwol
#1073 remove some fully duplicate functions
5c0f26a
gabrielwol added a commit that referenced this issue Sep 17, 2024
@gabrielwol
#1073 combine send_request, get_request_id, get_download_link in orde…
5d9099a 
…r to add retry on access_token while maintaining request_id.
gabrielwol added a commit that referenced this issue Sep 17, 2024
@gabrielwol
#1073 improve flow
5fd678b
@gabrielwol gabrielwol linked a pull request Sep 17, 2024 that will close this issue
Open
@gabrielwol gabrielwol linked a pull request Sep 17, 2024 that will close this issue
1073 here pull token expired error #1074
Open
gabrielwol added a commit that referenced this issue Sep 17, 2024
@gabrielwol
#1073 fix imports from here_api
311b608
gabrielwol added a commit that referenced this issue Sep 23, 2024
@gabrielwol
#1073 move token refresh to get_download_url
a3ad13b
gabrielwol added a commit that referenced this issue Sep 24, 2024
@gabrielwol
#1073 revert back to 3 separate tasks, with access_token retry inside…
042b1a7 
… get_download_link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrielwol gabrielwol

Labels
bug here
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1073 here pull token expired error CityofToronto/bdit_data-sources
2 participants
@radumas @gabrielwol