Miovision Aggregation Improvements (ATR view, intersection_movements AFTER INSERT trigger, unacceptable_gaps) #1024
+413
−578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unacceptable_gaps)
|
Testing the new ATR view for speed: --test: 0.2 s with primary key
SELECT *
FROM miovision_api.volumes_15min_atr_filtered
WHERE
intersection_uid = 6
AND classification_uid = 1
AND datetime_bin = '2024-06-25 12:00:00'
AND leg <> LEFT(dir, 1);
--DR i0627 test using new view
--41s for original, 1:06 for view (1.3M rows)
SELECT
volumes.intersection_uid,
date_trunc('hour', volumes.datetime_bin) AS datetime_bin,
volumes.leg,
volumes.dir,
classifications.classification,
SUM(volumes.volume) AS volume
FROM miovision_api.volumes_15min_atr_filtered AS volumes
INNER JOIN miovision_api.classifications USING (classification_uid)
WHERE
volumes.classification_uid NOT IN (2, 7)
AND volumes.datetime_bin >= '2024-01-01'
AND volumes.datetime_bin < '2024-05-22'
AND volumes.intersection_uid IN (76, 88, 81, 85, 84, 87, 75, 83, 86, 49, 80, 36)
GROUP BY
volumes.intersection_uid,
classifications.classification,
date_trunc('hour', volumes.datetime_bin),
volumes.leg,
volumes.dir; |
gabrielwol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull request accomplishes:
miovision_api.volumes_15min(table) in place of view (volumes_15min_atr_filtered). Reduces duplicate storage (~75GB) and complexity in aggregation.AFTER INSERTtrigger tointersection_movementsto help aggregate and pad new movements into volumes_15min_mvt.new_rows(transition relation) instead ofintersection_movementsand without date limits.unacceptable_gapremoval from table inserts to filtered view: less complexity in adding and removing unacceptable_gaps.Summary of files changed:
Many files have minor changes including renamed references, removal of ATR aggregation, big fluff (intersection_movements, volumes_15min_tmc).
Files with major changes:
movement_mapwith entry/exit leg columns and directions more clearly labelled. Helps with ATR view joins.Issue(s) this solves:
unacceptable_gapsvia viewintersection_movements: Big list ofmiovision.intersection_movementinconsistencies and bugs #406, Need to monitor intersection_movements for missing high volume movements #855What, in particular, needs to reviewed:
entry_dir, exit_leg, exit_dirto TMC table so ATR view wouldn't need to join to movement_map. Downside: more confusing TMC table, does not match current TMC table.What needs to be done by a sysadmin after this PR is merged
E.g.: these tables need to be migrated/created in the production schema.