Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file has a setting that is hardcoded in the Postgres #23

Open
cczhu opened this issue Nov 20, 2019 · 0 comments
Open

Configuration file has a setting that is hardcoded in the Postgres #23

cczhu opened this issue Nov 20, 2019 · 0 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation refactoring Reworking code structure without (major) API changes

Comments

@cczhu
Copy link
Contributor

cczhu commented Nov 20, 2019

As of #22, Traffic Prophet has a 'min_counts_in_day' setting for the smallest number of counts in a day for that day to be included in daily_counts. This is used when reading data from zip files, but because the Postgres materialized views we're working with already aggregate to daily counts, this minimum count number is hardcoded in the view scripts and setting 'min_counts_in_day' cannot affect this.

Potential solutions

  • At the very least this issue should be included in the documentation.
  • We could add an n_bins column to the Postgres views, which would allow selecting on a minimum bin coverage. This might further complicate the ETL pipeline, but should be considered when we refactor countmatch.reader.
@cczhu cczhu added bug Something isn't working documentation Improvements or additions to documentation refactoring Reworking code structure without (major) API changes labels Nov 20, 2019
@cczhu cczhu self-assigned this Nov 20, 2019
@cczhu cczhu changed the title Configuration file has a setting that is hardecoded in the Postgres Configuration file has a setting that is hardcoded in the Postgres Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation refactoring Reworking code structure without (major) API changes
Projects
None yet
Development

No branches or pull requests

1 participant