Upd. Phones encoding. Test coverage improved.

Author: alexandergull

lib/Cleantalk/ApbctWP/ContactsEncoder/ContactsEncoder.php

@@ -327,7 +327,7 @@ public static function getPhonesEncodingLongDescription()
             <p>%s</p>
         ';
         $tmp = sprintf(
-            $tmp,
+            trim($tmp),
             __('Enable this option to encode contact phone numbers', 'cleantalk-spam-protect'),
             __('There are a few requirements to the number format:', 'cleantalk-spam-protect'),
             __('Should starting with "+" symbol or opening brace', 'cleantalk-spam-protect'),

lib/Cleantalk/Common/ContactsEncoder/ContactsEncoder.php

@@ -166,6 +166,7 @@ public function runEncoding($content = '')
      *
      * @return string JSON like {success: bool, data: [compiled response data]}
      * @psalm-suppress PossiblyUnusedMethod
+     * @codeCoverageIgnore
      */
     public function runDecoding($encoded_contacts_data)
     {

tests/ApbctWP/ContactsEncoder/TestContactsEncoder.php

@@ -37,6 +37,21 @@ public function testPlainTextEncodeDecodeSSL()
         $this->assertEquals($decoded_entity, $this->plain_text);
     }
 
+    public function testPlainTextDecodeError()
+    {
+        $decoded_entity = $this->contacts_encoder->encoder->decodeString('asdas121312');
+        $this->assertEmpty($decoded_entity);
+        $this->assertIsString($decoded_entity);
+        /**
+         * @var State $apbct
+         */
+        global $apbct;
+        $this->assertTrue($apbct->isHaveErrors());
+        $this->assertTrue($apbct->errorExists('email_encoder'), $this->plain_text);
+        $this->assertStringContainsString( 'decrypt attempts failed', $apbct->errors['email_encoder'][0]['error']);
+        $apbct->errorDeleteAll();
+    }
+
     public function testEncodeErrors()
     {
         /**
@@ -228,4 +243,12 @@ public function testPhoneEncodingSetting()
         $this->assertEquals($test_tel_origin, $result);
     }
 
+    public function testGetPhonesEncodingLongDescription()
+    {
+        $description = ContactsEncoder::getPhonesEncodingLongDescription();
+        $this->assertIsString($description);
+        $this->assertStringStartsWith('<', $description);
+        $this->assertStringEndsWith('>', $description);
+    }
+
 }