Skip to content

Commit f7e2ec9

Browse files
committed
Unskip exit signal handling
1 parent 8c039b7 commit f7e2ec9

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

tests/executors/test_executor.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@
1919
SLEEP_300 = "sleep 300"
2020

2121

22-
@pytest.mark.skipif(
23-
"platform.system() == 'Windows'", reason="Expects signal -15 gets 15"
24-
)
2522
@pytest.mark.parametrize("command", (SLEEP_300, SLEEP_300.split()))
2623
def test_running_process(command):
2724
"""Start process and shuts it down."""
@@ -36,9 +33,6 @@ def test_running_process(command):
3633
assert SLEEP_300 in str(executor)
3734

3835

39-
@pytest.mark.skipif(
40-
"platform.system() == 'Windows'", reason="Expects signal -15 gets 15"
41-
)
4236
@pytest.mark.parametrize("command", (SLEEP_300, SLEEP_300.split()))
4337
def test_command(command):
4438
"""Check that the command and command parts are equivalent."""

tests/executors/test_executor_kill.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,10 @@ def test_daemons_killing():
9191

9292
@pytest.mark.skipif(
9393
"platform.system() == 'Windows'",
94-
reason="Expects signal -15 gets 15 at the last stop",
94+
reason=(
95+
"Subprocess killed earlier than in 10 secs. "
96+
"Blocking signals probably doesn't work."
97+
),
9598
)
9699
def test_stopping_brutally():
97100
"""

0 commit comments

Comments
 (0)