Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows test failures #262

Merged
merged 29 commits into from
Dec 2, 2024
Merged

Fix windows test failures #262

merged 29 commits into from
Dec 2, 2024

Conversation

odunbar
Copy link
Collaborator

@odunbar odunbar commented Dec 11, 2023

Purpose

Posted this issue to SciKitLearn.jl as it appears like it is on their side.

Content

  • Running with newer test pipelines
  • Running with newer versions of python packages
  • add a more noticeable test for when python package updates fail

  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.82%. Comparing base (acf1051) to head (e2a48f3).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   88.17%   88.82%   +0.65%     
==========================================
  Files           8        7       -1     
  Lines        1184     1271      +87     
==========================================
+ Hits         1044     1129      +85     
- Misses        140      142       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odunbar
Copy link
Collaborator Author

odunbar commented Dec 2, 2024

CI and test-pipeline changes, leading to passing tests with latest python and on all platforms with latest julia versions

@odunbar odunbar merged commit a39e67a into main Dec 2, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant