Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mul_with_projection/rmul_with_projection to Geometry module #1831

Closed
charleskawczynski opened this issue Jun 19, 2024 · 1 comment · Fixed by #1832
Closed

Move mul_with_projection/rmul_with_projection to Geometry module #1831

charleskawczynski opened this issue Jun 19, 2024 · 1 comment · Fixed by #1832
Assignees
Labels

Comments

@charleskawczynski
Copy link
Member

These two methods are pretty tied to the geometry module, and don't depend on anything else. Moving them to the Geometry module will allow us to test the Geometry module with a wider set of inputs (and, eg., test for inference).

For example, #1828 is passing the Geometry tests, but then fail downstream, even though those changes only pertain to the geometry module.

@charleskawczynski
Copy link
Member Author

In addition, we should add more inference tests to the geometry module, as we're having many issues in MatrixField inference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant