Skip to content

River states should be updated in-place, #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odunbar opened this issue Jan 8, 2025 · 0 comments
Open

River states should be updated in-place, #34

odunbar opened this issue Jan 8, 2025 · 0 comments

Comments

@odunbar
Copy link
Member

odunbar commented Jan 8, 2025

Issue

river_state = compute_river_state(date_window, river_model, env)

We create new states at every iterating time-step during integration of the river model. This may be quite expensive (see the PR #24)

Possible solution

  • Overwrite the state by default using in-place updates.
  • Create a diagnostic interface to create a full state (history) copy to save at allocated frequency/dates
  • Creation of some simple reduced file output of e.g. streamflow-per-basin that can be used for plotting etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant