errors in diffusive_ice_column_model.jl

[francispoulin]

diffusive_ice_column_model.jl defines two functions to be functions of (x, y, t), but the right hand side only depends on t and this causes an error.

In the current state of affairs, I think we need make the following changes:

ClimaSeaIce.jl/examples/diffusive_ice_column_model.jl

Line 31 in 2dee0f4

air_ice_temperature(x, y, t) = top_T_slope * t + top_T_amplitude * sin(2π*t/day) + initial_air_ice_temperature

should become

air_ice_temperature(t) = top_T_slope * t + top_T_amplitude * sin(2π*t/day) + initial_air_ice_temperature

and

ClimaSeaIce.jl/examples/diffusive_ice_column_model.jl

Line 32 in 2dee0f4

ice_ocean_temperature(x, y, t) = bottom_T_slope * t + initial_ice_ocean_temperature

should become

ice_ocean_temperature(t) = bottom_T_slope * t + initial_ice_ocean_temperature

With these changes plotting needs to be changes slightly in lines 42, 43, 189, and 190.

Do people agree?

[glwagner]

What matters is that the grid is Flat in x, y:

ClimaSeaIce.jl/examples/diffusive_ice_column_model.jl

Line 13 in 2dee0f4

grid = RectilinearGrid(size=20, z=(-1, 0), topology=(Flat, Flat, Bounded))

Since it is, then I agree the boundary conditions should be functions of t only.

[glwagner]

PS, for code blocks, use triple backticks "```", rather than just a single backtick "`"