Errors in cooling_then_warming_ocean.jl

[francispoulin]

I have found some errors in this script but I don't know the library well enough to proposes fixes.

First, this line can be removed as there is no longer a HeatBoundaryConditions.

ClimaSeaIce.jl/validation/ice_ocean_model/cooling_then_warming_ocean.jl

Line 8 in 2dee0f4

using ClimaSeaIce.HeatBoundaryConditions: RadiativeEmission, IceWaterThermalEquilibrium

It sems that RadiativeEmission is already imported by ClimaSeaIce.jl. But I have not found an IceWaterThermalEquilibrium. Maybe the name has changed?

Second, IceWaterThermalEquilbrium is not defined but is called in the line below. Maybe the name has changed?

ClimaSeaIce.jl/validation/ice_ocean_model/cooling_then_warming_ocean.jl

Line 66 in 2dee0f4

bottom_bc = IceWaterThermalEquilibrium(ocean_surface_salinity)

Third, SlabSeaIceModel is not defined but is called in line 97.

ClimaSeaIce.jl/validation/ice_ocean_model/cooling_then_warming_ocean.jl

Line 97 in 2dee0f4

coupled_model = IceOceanModel(ice_simulation, ocean_simulation)

[glwagner]

@simone-silvestri

[simone-silvestri]

There are some leftovers from the refactor that I have to address. In particular, I have not adapted the validation cases to the new syntax. I will deal with this in a new PR

[glwagner]

I think this is an example, so it may also need to be put into the docs

[simone-silvestri]

I am unsure about using this as an example because it uses a hacky IceOceanModel.
I would revamp this by using ClimaOcean and it's own OceanSeaIceModel

[glwagner]

Ah ok, then let's scrap it. I'm not sure we should put ClimaOcean into ClimaSeaIce examples. For example, we don't use ClimaOcean in Oceananigans examples.