Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Resource previews script parallelisation #218

Open
VeckoTheGecko opened this issue May 18, 2023 · 1 comment
Open

[FEATURE] Resource previews script parallelisation #218

VeckoTheGecko opened this issue May 18, 2023 · 1 comment
Labels
coding Change that requires coding enhancement New feature or request for the website good first issue Good for new developers help wanted Extra attention is needed 🟠medium priority A medium priority feature

Comments

@VeckoTheGecko
Copy link
Collaborator

Describe your suggested improvement
The get_og_previews.py script is currently run sequentially for each resource. Running this in parallel would result in better build speeds for the website.

Describe the benefit
Build speed

Would you be capable/willing to implement the improvement?
Perhaps. Happy for a community member to claim this.

Additional comments

@VeckoTheGecko VeckoTheGecko added enhancement New feature or request for the website good first issue Good for new developers coding Change that requires coding 🟠medium priority A medium priority feature help wanted Extra attention is needed labels May 18, 2023
@Lyrete
Copy link
Contributor

Lyrete commented Dec 30, 2023

Pretty bored so will probably start looking at this later today or tomorrow :) Will ditch urllib for httpx and should be relatively simple to get going after that.

Can rescale too but as mentioned in #373 I think it's probably nice to just leave this for Svelte to deal with (or rather more futureproof if there's ever a change in the card format). Could however ditch previews that are too small to use pre-scaling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coding Change that requires coding enhancement New feature or request for the website good first issue Good for new developers help wanted Extra attention is needed 🟠medium priority A medium priority feature
Projects
None yet
Development

No branches or pull requests

2 participants