Skip to content

spec: remove InfoURL in ModelDescriptor #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025
Merged

spec: remove InfoURL in ModelDescriptor #29

merged 1 commit into from
Feb 11, 2025

Conversation

aftersnow
Copy link
Contributor

@aftersnow aftersnow commented Feb 11, 2025

The filed InfoURL is no longer necessary, and seems confusing.

See the discussion.

Signed-off-by: Zhao Chen zhaochen.zju@gmail.com

The filed InfoURL is no longer necessary, and seems confusing.

See the [discussion](https://cloud-native.slack.com/archives/C07T0V480LF/p1739257048027399?thread_ts=1739251984.440139&cid=C07T0V480LF).

Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 418d454 into main Feb 11, 2025
2 checks passed
@chlins chlins deleted the remove-infourl branch February 11, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants