Skip to content

feat: optimize definition of the model spec #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

feat: optimize definition of the model spec #31

merged 1 commit into from
Feb 12, 2025

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Feb 11, 2025

This pull request includes significant updates to the documentation and codebase related to the handling of AI/ML model artifacts. The changes primarily focus on refining the specification, updating media types, and cleaning up deprecated annotations.

Documentation Updates:

  • Removed outdated model annotation keys from docs/annotations.md to streamline the documentation.
  • Added new media types and clarified the use of artifactType and mediaType in docs/spec.md.
  • Updated the +gzip and +zstd media types to include new entries for configuration files in docs/spec.md.

Codebase Changes:

  • Removed deprecated annotation keys from specs-go/v1/annotations.go.
  • Renamed CreateTime to CreatedAt in specs-go/v1/config.go to standardize naming conventions.
  • Updated media type constants and added new ones for configuration files in specs-go/v1/mediatype.go.

@gaius-qi gaius-qi added the enhancement New feature or request label Feb 11, 2025
@gaius-qi gaius-qi self-assigned this Feb 11, 2025
Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link
Contributor

@aftersnow aftersnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 7aabe2b into main Feb 12, 2025
2 checks passed
@chlins chlins deleted the feature/spec branch February 12, 2025 03:06
@aftersnow aftersnow mentioned this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants