From e67298ad7099fe02e6b676f2d8806642b3f55fe4 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Sat, 19 Nov 2022 21:49:59 +0000 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne --- .../src/main/java/eu/cloudopting/bpmn/BpmnService.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bpmn-component/src/main/java/eu/cloudopting/bpmn/BpmnService.java b/bpmn-component/src/main/java/eu/cloudopting/bpmn/BpmnService.java index 2e0e37dd..1dee73e5 100644 --- a/bpmn-component/src/main/java/eu/cloudopting/bpmn/BpmnService.java +++ b/bpmn-component/src/main/java/eu/cloudopting/bpmn/BpmnService.java @@ -4,6 +4,7 @@ import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; +import java.nio.file.Files; import java.util.ArrayList; import java.util.HashMap; import java.util.HashSet; @@ -52,6 +53,7 @@ import eu.cloudopting.service.UserService; import eu.cloudopting.service.util.StatusConstants; import eu.cloudopting.store.StoreService; + //import scala.collection.concurrent.Debug; @@ -266,7 +268,7 @@ public ActivitiDTO startUpdate(Long applicationId, Organizations org) { public static File stream2file (String uploadName, InputStream in) throws IOException { - final File tempFile = File.createTempFile(uploadName+BpmnService.TEMP_FILE_NAME_SEPARATOR, "tmp"); + final File tempFile = Files.createTempFile(uploadName + BpmnService.TEMP_FILE_NAME_SEPARATOR, "tmp").toFile(); tempFile.deleteOnExit(); try (FileOutputStream out = new FileOutputStream(tempFile)) { IOUtils.copy(in, out);