Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add Testing Capability to Validate Site Metadata #58

Open
chrisreddington opened this issue Feb 8, 2022 · 3 comments
Open
Labels
Community/GoodFirstIssue Good for newcomers Community/HelpWanted Extra attention is needed Priority/High This is of high priority. It should be prioritised over medium and low items. Type/Enhancement New feature or request Type/Maintenance Something required to keep the project healthy.
Milestone

Comments

@chrisreddington
Copy link
Contributor

Provide a general summary of the suggestion

Based on recent experience, it can be quite a temperamental experience (i.e. to output the appropriate Hugo variables in the correct way for escaping strings for example).

To prevent against this, it is important to have a more thorough testing as part of the PR process.

Context

One of the great features of the theme is that it has a strong focus on SEO. However, as new features are introduced, contributors will need to update the site metadata templates.

Possible Implementation

  • Run hugo --minify with an example --baseURL in the GitHub Action. If there is a rendering issue, it will be caught there.
  • Could complete some linting on the build output
  • Could check that outputted URLs on the build output's JSON are well-formed.

Your Environment

No response

@chrisreddington chrisreddington added the Type/Enhancement New feature or request label Feb 8, 2022
@chrisreddington chrisreddington added Community/GoodFirstIssue Good for newcomers Community/HelpWanted Extra attention is needed Type/Maintenance Something required to keep the project healthy. Priority/High This is of high priority. It should be prioritised over medium and low items. labels Feb 8, 2022
@chrisreddington
Copy link
Contributor Author

@chrisreddington chrisreddington added this to the Initial Beta +1 milestone Feb 22, 2022
@chrisreddington chrisreddington moved this from Triage to Accepted in Hugo Creator Project Apr 2, 2022
@chrisreddington
Copy link
Contributor Author

Connected to CloudWithChris/cloudwithchris.com#1183. Will be able to re-use tests from there on the exampleSite implementation within this repo.

@chrisreddington
Copy link
Contributor Author

This has been completed in CloudWithChris/cloudwithchris.com.

Can port over retrospectively if needed, but closing this issue for now, as no known users using the theme :)

Repository owner moved this from Accepted to Done in Hugo Creator Project Jun 3, 2022
Repository owner moved this from Done to Review Needed in Hugo Creator Project Sep 10, 2022
@chrisreddington chrisreddington modified the milestones: 2022-Q2, 2022-Q4 Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community/GoodFirstIssue Good for newcomers Community/HelpWanted Extra attention is needed Priority/High This is of high priority. It should be prioritised over medium and low items. Type/Enhancement New feature or request Type/Maintenance Something required to keep the project healthy.
Projects
Status: Done
Status: Review Needed
Development

No branches or pull requests

1 participant