-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP-21861 CP-21958]: Modify Generate Command to Update Pod ConfigMap with Service Endpoints #33
Conversation
General comment, you likely want to try this in combination with a local version of the chart - with the related updates. We will need to know what permissions or other data we might need set in the chart. This way you can also verify the chart results when running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This PR modifies the
generate
command to update the Service Endpoints for both Node Exporter and KSM.Testing
The updated command and it's output:
cloudzero-agent-validator git:(cp-21861) ./bin/cloudzero-agent-validator config generate --kubeconfig /tmp/bdren.kubeconfig --account 123 --cluster test --region us-east-1 --namespace default --configmap cz-prom-agent-configuration --pod cz-prom-agent-cloudzero-agent-server-5b54bdfbbc-b9xgk
The output should look the same as before, but behind the scenes the ConfigMap is being updated. For real-world results, see Cloudzero/cloudzero-charts#78.