Conversation
dmepham
approved these changes
Sep 20, 2024
evan-cz
pushed a commit
that referenced
this pull request
Jan 13, 2025
…r/setup-buildx-action-3.7.1 Bump docker/setup-buildx-action from 3.6.1 to 3.7.1
evan-cz
pushed a commit
that referenced
this pull request
Apr 1, 2025
* added fix for apiKey update secret.yaml to check for validity of apiKey before installation updated GH action to match that of public repo (not part of this ticket) * CP-18169 scrape improvements updated the scrape config for cAdvisor to only scrape the metrics we need. * Refactor of scrape config Refactored the configmap template to pull out the list of metrics we scrape and send Added a helper function to combine the list of metrics we send Updated values.yaml to have list of metrics we need to function correctly * Changed metric names in values.yaml updated the names of the metrics we collect in vaules.yaml for clarity updated messaging about modification of the metrics lists * updated changelog * it's scrape, not crape * CP-18625: fix README kube pod labels working * update changelog with fix info * clean up persistent volumes (#2) * clean up persistent volumes refactored pvc.yaml to remove volumeBindingMode and clean up logic updated PV name to be less generic by prefacing with cloudzero-agent so it's easier to tell what the volume is and what it's purpose is * changed cz-agent to cloudzero agent for consistency * refactor PVC.yaml and updated values.yaml to match * fixed typo in values.yaml * Updated CHANGELOG.md * remove extra separator (#5) * remove extra separator removed exta separator in cm.yaml. the config map would fail to load on fresh install with this entry * Updated CHANGELOG.md * CP-18830: fix typos * typo fixes * CP-18722 (#7) * Added CPU/Memory requests and limits Added CPU Requests and no limit. Also added Memory requests and limits to deploy.yaml and corresponding values in values.yaml. Updated CHANGELOG.md * Increased Memory requests and limits * Updates from PR * add deployment eco system validation support * address feedback on guide * add a few new ignores * refactor deployment to use image * move script into container image and python script * add unit testing * add makefile for dev QOL * remove testing secret reference * add chart lint testing action pipeline * test branch is available via simple env variables * add seperate step to get branch name * try simple ref branch name variable * fix a lint issue to validate list-changes detection works in CI * fix another lint issue to validate list-changes detection works in CI * use more robust change list action * test to validate pipeline * better change detection * force change detection rule * CP-19160 add kind to support helm install testing * whitespace change to force test * CP-19160 add docker actions pipeline for validator image * minor changes to ensure we control when we are publishing, while still allowing builds on PR * CP-19160 add condition for push * CP-19160 fix env usage * CP-19160 minor changes to events, and tag rules * CP-19160 remove sha push * CP-19160 add PR image cleanup * CP-19160 add PR image cleanup * CP-19160 clarify event and tagging rules with comments * CP-19160 cleanup comments * CP-19160 add a few important labels to image * fix addressing error * CP-19160 allow PR images to push * CP-19160 abstract repo name to make merge to public repo easier * CP-19160 set push parameter for docker build action * refactor to make reusable workflow * refactor to make reusable workflow * refactor to use reusable workflow * modify the event conditions * CP-19508 test to resolve permissoin issue * test: add secret from calling workflow * test 2: pushing in push token * try using github.token * test with env scope * test using repo variable * rollback tests * rollback tests * test again * CP-19508: refactor workflows to solve permissions issues with forks * remove remote find qualifier * join the test jobs into one file * rename and comment jobs * rename and comment jobs * ensure steps meet formatting standards * ensure steps meet formatting standards * test other steps should work on develop branches * rollback to install instead of upgrade with CT * fix publish conflict for local registry * enhance step names * add back publish step conditionals * fix filename * remove old files * fix linting issue * add docs for CICD * improve documentation --------- Co-authored-by: Robert Hocking <rob.hocking@cloudzero.com> Co-authored-by: Robert Hocking <12814465+roberthocking@users.noreply.github.com> Co-authored-by: Daniel Mepham <daniel.mepham@cloudzero.com>
josephbarnett
added a commit
that referenced
this pull request
Jul 25, 2025
* added fix for apiKey update secret.yaml to check for validity of apiKey before installation updated GH action to match that of public repo (not part of this ticket) * CP-18169 scrape improvements updated the scrape config for cAdvisor to only scrape the metrics we need. * Refactor of scrape config Refactored the configmap template to pull out the list of metrics we scrape and send Added a helper function to combine the list of metrics we send Updated values.yaml to have list of metrics we need to function correctly * Changed metric names in values.yaml updated the names of the metrics we collect in vaules.yaml for clarity updated messaging about modification of the metrics lists * updated changelog * it's scrape, not crape * CP-18625: fix README kube pod labels working * update changelog with fix info * clean up persistent volumes (#2) * clean up persistent volumes refactored pvc.yaml to remove volumeBindingMode and clean up logic updated PV name to be less generic by prefacing with cloudzero-agent so it's easier to tell what the volume is and what it's purpose is * changed cz-agent to cloudzero agent for consistency * refactor PVC.yaml and updated values.yaml to match * fixed typo in values.yaml * Updated CHANGELOG.md * remove extra separator (#5) * remove extra separator removed exta separator in cm.yaml. the config map would fail to load on fresh install with this entry * Updated CHANGELOG.md * CP-18830: fix typos * typo fixes * CP-18722 (#7) * Added CPU/Memory requests and limits Added CPU Requests and no limit. Also added Memory requests and limits to deploy.yaml and corresponding values in values.yaml. Updated CHANGELOG.md * Increased Memory requests and limits * Updates from PR * add deployment eco system validation support * address feedback on guide * add a few new ignores * refactor deployment to use image * move script into container image and python script * add unit testing * add makefile for dev QOL * remove testing secret reference * add chart lint testing action pipeline * test branch is available via simple env variables * add seperate step to get branch name * try simple ref branch name variable * fix a lint issue to validate list-changes detection works in CI * fix another lint issue to validate list-changes detection works in CI * use more robust change list action * test to validate pipeline * better change detection * force change detection rule * CP-19160 add kind to support helm install testing * whitespace change to force test * CP-19160 add docker actions pipeline for validator image * minor changes to ensure we control when we are publishing, while still allowing builds on PR * CP-19160 add condition for push * CP-19160 fix env usage * CP-19160 minor changes to events, and tag rules * CP-19160 remove sha push * CP-19160 add PR image cleanup * CP-19160 add PR image cleanup * CP-19160 clarify event and tagging rules with comments * CP-19160 cleanup comments * CP-19160 add a few important labels to image * fix addressing error * CP-19160 allow PR images to push * CP-19160 abstract repo name to make merge to public repo easier * CP-19160 set push parameter for docker build action * refactor to make reusable workflow * refactor to make reusable workflow * refactor to use reusable workflow * modify the event conditions * CP-19508 test to resolve permissoin issue * test: add secret from calling workflow * test 2: pushing in push token * try using github.token * test with env scope * test using repo variable * rollback tests * rollback tests * test again * CP-19508: refactor workflows to solve permissions issues with forks * remove remote find qualifier * join the test jobs into one file * rename and comment jobs * rename and comment jobs * ensure steps meet formatting standards * ensure steps meet formatting standards * test other steps should work on develop branches * rollback to install instead of upgrade with CT * fix publish conflict for local registry * enhance step names * add back publish step conditionals * fix filename * remove old files * fix linting issue * add docs for CICD * improve documentation --------- Co-authored-by: Robert Hocking <rob.hocking@cloudzero.com> Co-authored-by: Robert Hocking <12814465+roberthocking@users.noreply.github.com> Co-authored-by: Daniel Mepham <daniel.mepham@cloudzero.com>
josephbarnett
pushed a commit
that referenced
this pull request
Jul 25, 2025
[CP-21861 (part-2)]: Use Namespace Arguement
josephbarnett
added a commit
that referenced
this pull request
Jul 25, 2025
…r/setup-buildx-action-3.7.1 Bump docker/setup-buildx-action from 3.6.1 to 3.7.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a small miss #33, essentially we need to use the argument
namespace, rather than"default".