Conversation
bdrennz
commented
Nov 22, 2024
| namespace = "prom-agent" | ||
| serviceName = "cz-prom-agent-kube-state-metrics" |
Contributor
Author
There was a problem hiding this comment.
Note: Need namespace and serviceName to be passed as args.
bdrennz
changed the title
bdrennz
commented
Nov 25, 2024
| c.logger.Infof("Address: %v", address) | ||
| for _, port := range subset.Ports { | ||
| c.logger.Infof("Port: %v", port) | ||
| if port.Port == 8080 { |
Contributor
Author
There was a problem hiding this comment.
Port should be an arg
bdrennz
commented
Nov 25, 2024
| } | ||
|
|
||
| metrics := string(body) | ||
| requiredMetrics := []string{"kube_pod_info", "kube_node_info"} // Add the required metrics here |
Contributor
Author
There was a problem hiding this comment.
Note: Pass all Chart metrics via validator config file
bdrennz
commented
Nov 27, 2024
| run: | | ||
| go test -timeout 30s -race -cover ./... | ||
| #go test -timeout 30s -race -cover ./... | ||
| go test -v ./pkg/diagnostic/kms/ |
Contributor
Author
There was a problem hiding this comment.
note: Change back after testing
evan-cz
pushed a commit
that referenced
this pull request
Jan 13, 2025
evan-cz
pushed a commit
that referenced
this pull request
Apr 1, 2025
* Add sizing guide * Update/Streamline README
josephbarnett
added a commit
that referenced
this pull request
Jul 25, 2025
* Add sizing guide * Update/Streamline README
josephbarnett
pushed a commit
that referenced
this pull request
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the
kube_state_metrics_reachablepost-startjob to also validate that all CloudZero KMS metrics are available. A sample log output:{ "level": "info", "log_sequence": 6, "msg": "Using endpoint URL: http://192.168.5.249:8080/metrics", <---- Internal IP discovered using the Service Endpoint "op": "ksm", "time": "2024-11-25T08:23:44Z" } { "level": "info", "log_sequence": 7, "msg": "All required metrics found: [kube_pod_info kube_node_info]", <---- Metric Check (subset for now) "op": "ksm", } Part of the Cluster Status Report related to KMS: {\"name\":\"kube_state_metrics_reachable\",\"passing\":true}]}",