Cp 19161 ensure we have good testing on new validator code (#36)

* CP-19161 add file changed check to makefile

* CP-19161 simplify file changed check to makefile

* even simpler

* CP-19161 add simple workflow to run python checks

* test purposely break build to test pipeline

* revert change after pipeline validation

* change matrix for current versions

* reduce test matrix to match dockerfile only python 3.12

Author: josephbarnett

.github/workflows/test-python.yml

@@ -0,0 +1,48 @@
+name: test_python
+on:
+  push:
+  pull_request:
+
+env:
+  # build docker images to the (host) local registry
+  REGISTRY_LOCAL_ADDR: localhost:5000
+  # k8x requires the kind container address alias (comes from the kind-action)
+  REGISTRY_TEST_ADDR: kind-registry:5000
+  # If we are on develop or main, use the production repository
+  REGISTRY_PROD_ADDR: ghcr.io
+  # image name should be prefixed with the repository name
+  IMAGE_NAME: ${{ github.repository }}/cloudzero-agent-validator
+  
+jobs:
+  # This job detects if there are any changes to allow condition testing in other jobs
+  has_changes:
+    uses: ./.github/workflows/change-detector.yml
+  
+  test_python:
+    runs-on: ubuntu-latest
+    needs: has_changes
+    permissions:
+      contents: read
+    strategy:
+      matrix:
+        python-version: ["3.12"]
+    steps:
+    - name: SETUP - Checkout
+      if: needs.has_changes.outputs.any_changed == 'true'
+      uses: actions/checkout@v4
+
+    - name: SETUP - Python ${{ matrix.python-version }}
+      if: needs.has_changes.outputs.any_changed == 'true'
+      uses: actions/setup-python@v5
+      with:
+        python-version: ${{ matrix.python-version }}
+
+    - name: SETUP - Display Python version
+      if: needs.has_changes.outputs.any_changed == 'true'
+      run: |
+        python -c "import sys; print(sys.version)"
+
+    - name: TEST - Run checks
+      run: |
+        cd charts/cloudzero-agent
+        make check

charts/cloudzero-agent/Makefile

@@ -82,12 +82,17 @@ clean: ## Clean up dangling Docker images
 fmt: init-dev ## runs code formatter
 	@$(PYTHON_ARGS) black $(SRC_DIR)/*.py $(TEST_DIR)/*.py
 
+.PHONY: fmt-check
+fmt-check: fmt ## Check if the code is properly formatted
+	$(eval CHANGED := $(shell git status -s | grep "\.py" | wc -c))
+	@[ $(CHANGED) -eq 0 ] || { echo "changed files"; exit 1; }
+
 .PHONY: lint
 lint: init-dev ## runs code linter
 	@$(PYTHON_ARGS) ruff check $(SRC_DIR) $(TEST_DIR)
 
 .PHONY: check
-check: lint test ## Run code linter and unit tests
+check: fmt-check lint test ## Run code linter and unit tests
 
 .PHONY: test
 test: check-python-version init-dev ## Run unit tests