Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar current tab is not changing color #571

Open
RavindraP04 opened this issue Apr 8, 2023 · 15 comments
Open

Navbar current tab is not changing color #571

RavindraP04 opened this issue Apr 8, 2023 · 15 comments
Assignees

Comments

@RavindraP04
Copy link
Member

As you can see in the, AboutUs page is open but the Tab color green in the navbar is still on Home tab
fix this for all the tabs
image

@tejash023
Copy link

Hi, Can I work on this issue?

@RavindraP04
Copy link
Member Author

Sure go ahead @tejash023

@SaurabhBarde-007
Copy link

Hi I can work on this issue

@tejash023
Copy link

Hi, I am already working on this and will be creating the PR tom

@mukeshkuiry
Copy link
Member

Hi, I am already working on this and will be creating the PR tom
okay 👌

@Debajyoti14
Copy link
Member

@tejash023 What's the progress?

@mukeshkuiry
Copy link
Member

@tejash023 ???

@tejash023
Copy link

hey @bbsdevloper I have made changes but possible stuck at the header #hero section where, while changing the url, to home in the same page i.e from Open source project link to home, the router is not re-rendering and thus current is set to false.

image

Working on about:
image

Please let me know if I am missing something. Thanks

@Debajyoti14
Copy link
Member

@tejash023 Make a PR.
We will check then what needs to be done

@AkshayPratapSingh09
Copy link

I Think I can Give this one a try If U assign me this One..

@mani200307
Copy link

@RavindraP04, Could you please assign me this issue? I could work on that.

@RavindraP04 RavindraP04 assigned mani200307 and unassigned tejash023 May 19, 2023
@RavindraP04
Copy link
Member Author

Assigned @mani200307

@agap-0251
Copy link

The problem is that we are not updating the "current" property of navbar "a" tags when we are moving to different routes. I have adjusted the navbar color change issue. Here is the code..

Screenshot (42)

And here is the preview...
clueless

I know that someone has used same thing . But since the issue is not closed, I tried to solve the issue. I think the issue is solved. If there is something wrong, please let me know.

@agap-0251
Copy link

@RavindraP04 could you assign me for this ?

RavindraP04 added a commit that referenced this issue Jul 16, 2023
@agap-0251
Copy link

The current navbar colour is not changing according to the page, I have already proposed a solution above. Could you assign me for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants