-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for proxies #976
Comments
Hi there! Thanks for opening this issue. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible. |
Go ahead @Siddhesh-Agarwal Note
All the best 👨💻 |
@nikhil25803 Here is how I am thinking of solving this problem:
Here is the step I have some confusion about:
|
Yes go ahead. But for now add request timeout feature only. |
Hey, Rewriting every request in the project, every time more features are added, doesn't seem very maintainable. I am adding a new |
@nikhil25803 I have added support for |
Hey @nikhil25803 Can I create a PR for Proxy support as well? It is a small 7-8 line addition in one file |
Yeah go ahead @Siddhesh-Agarwal |
Describe the feature
As a web scrapping library, supporting Proxies while sending requests would be useful. I propose a
RequestConfig
class where we can set the request timeout, proxies, redirect, etc.Add ScreenShots
The class would look something like this:
It should also be passable to Different Scrapers.
Record
The text was updated successfully, but these errors were encountered: