-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Testimonials Readme #1986
Comments
I would like to work on this issue please assign me |
Hi i would like to work on it under jwoc |
@RavindraP04 I have to include all the testimonials in the readme file ? |
@RavindraP04 photo are not working in many of files |
@KrunalGupta02 Not Working means Not Loading ? |
Not loading |
The problem I am facing is image is not loading and I how to center all the images I have tried the "width:100%" but it is looking good. |
@KrunalGupta02 First thing is width 100% will not work here and that is why you have to take all the screenshots in equal ratio so that it perfectly fits the cells and also you have to upload the screenshot of the components on https://imgbb.com/ otherwise it won't render |
@RavindraP04 |
@KrunalGupta02 For each component in which image is not loading, Raise an issue separately and one by one only(because won't be able to assign more than one issue at a time) then, I will assign you in it under jwoc marking all of then as easy OR you can do raise a single issue for all the image issue and I'll mark it as medium. |
Ok, I will raise a single issue for each component. |
@RavindraP04 , I would like to work on this issue under jwoc . Can you assingn it to me? |
Hey @RavindraP04 i want to work on it. |
@RavindraP04 what's the dead line for this issue. |
@prafulbbandre There is no deadline as such but can do asap, but now i guess you don't want to work on it |
@RavindraP04 Yes, please assign someone else for it. |
Hey devs I would like to work on this issue ! I think I would be able to pull this off easily!! |
Assigned @AkshayPratapSingh09 |
@RavindraP04 Many image seems to be not working in this Testimonial it says access denied |
Yes, That's what you have to update it, If you see the changes in the commit section of Testimonial, the components have been updated and so is their file names, so you have to take screenshot of each component and attach it with its corresponding code, so that when users click on any image, it redirects to the code of that component I don' think it will say access denied but if it does, Just check the readme, you will notice the file name or the file that image should redirect is either deleted of file name has been changed |
hello,is this issue open to work on? |
Need to improve this component on
Testimonials/readme.md
Improvements required :
Update the Testimonial readme as per newly designed Testimonials components
We have fully re-made whole
Testimonials
components as per our new design system, But theTestimonials/readme.md
are still of old design system,so now you have to copy paste the code of each component on play.tailwindcss.com and take screenshot of it, add that screenshot of the component in readme so that when someone clicks on that image, they will be redirected to the code of that particular component, All the images should be of equal aspect ratio like 16:9
The text was updated successfully, but these errors were encountered: