Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Testimonials Readme #1986

Open
RavindraP04 opened this issue Mar 1, 2023 · 21 comments
Open

Update Testimonials Readme #1986

RavindraP04 opened this issue Mar 1, 2023 · 21 comments
Labels
good first issue Good for newcomers HARD

Comments

@RavindraP04
Copy link
Member

RavindraP04 commented Mar 1, 2023

Need to improve this component on Testimonials/readme.md

Improvements required :

Update the Testimonial readme as per newly designed Testimonials components

We have fully re-made whole Testimonials components as per our new design system, But the Testimonials/readme.md are still of old design system,
so now you have to copy paste the code of each component on play.tailwindcss.com and take screenshot of it, add that screenshot of the component in readme so that when someone clicks on that image, they will be redirected to the code of that particular component, All the images should be of equal aspect ratio like 16:9

@RavindraP04 RavindraP04 changed the title Update Testimonial Readme Update Testimonials Readme Mar 1, 2023
@Priyamakeshwari
Copy link
Contributor

I would like to work on this issue please assign me

@KrunalGupta02
Copy link
Contributor

Hi i would like to work on it under jwoc

@KrunalGupta02
Copy link
Contributor

@RavindraP04 I have to include all the testimonials in the readme file ?

@KrunalGupta02
Copy link
Contributor

@RavindraP04 photo are not working in many of files

@RavindraP04
Copy link
Member Author

@RavindraP04 photo are not working in many of files

@KrunalGupta02 Not Working means Not Loading ?
Where are you uploading the image ?

@KrunalGupta02
Copy link
Contributor

Not loading
I am not uploading any image i only paste the HTML file in the tailwind playground

@KrunalGupta02
Copy link
Contributor

@RavindraP04
image

The problem I am facing is image is not loading and I how to center all the images I have tried the "width:100%" but it is looking good.
Kindly guide me on this.

@RavindraP04
Copy link
Member Author

@KrunalGupta02 First thing is width 100% will not work here and that is why you have to take all the screenshots in equal ratio so that it perfectly fits the cells and also you have to upload the screenshot of the components on https://imgbb.com/ otherwise it won't render

@KrunalGupta02
Copy link
Contributor

@RavindraP04
okk 👍🏻
and for the image in the components which is not loading what can i do

@RavindraP04
Copy link
Member Author

@KrunalGupta02 For each component in which image is not loading, Raise an issue separately and one by one only(because won't be able to assign more than one issue at a time) then, I will assign you in it under jwoc marking all of then as easy OR you can do raise a single issue for all the image issue and I'll mark it as medium.

@KrunalGupta02
Copy link
Contributor

Ok, I will raise a single issue for each component.

@Laxmankohar
Copy link
Contributor

@RavindraP04 , I would like to work on this issue under jwoc . Can you assingn it to me?

@prafulbbandre
Copy link
Contributor

Hey @RavindraP04 i want to work on it.

@prafulbbandre
Copy link
Contributor

prafulbbandre commented Mar 27, 2023

@RavindraP04 what's the dead line for this issue.

@prafulbbandre prafulbbandre removed their assignment Mar 28, 2023
@RavindraP04
Copy link
Member Author

RavindraP04 commented Mar 28, 2023

@RavindraP04 what's the dead line for this issue.

@prafulbbandre There is no deadline as such but can do asap, but now i guess you don't want to work on it

@prafulbbandre
Copy link
Contributor

@RavindraP04 Yes, please assign someone else for it.

@AkshayPratapSingh09
Copy link
Contributor

Hey devs I would like to work on this issue ! I think I would be able to pull this off easily!!

@RavindraP04
Copy link
Member Author

Hey devs I would like to work on this issue ! I think I would be able to pull this off easily!!

Assigned @AkshayPratapSingh09

@AkshayPratapSingh09
Copy link
Contributor

@RavindraP04 Many image seems to be not working in this Testimonial it says access denied

@RavindraP04
Copy link
Member Author

RavindraP04 commented Apr 24, 2023

@RavindraP04 Many image seems to be not working in this Testimonial it says access denied

Yes, That's what you have to update it, If you see the changes in the commit section of Testimonial, the components have been updated and so is their file names, so you have to take screenshot of each component and attach it with its corresponding code, so that when users click on any image, it redirects to the code of that component

I don' think it will say access denied but if it does, Just check the readme, you will notice the file name or the file that image should redirect is either deleted of file name has been changed

@Vivek-GuptaXCode
Copy link

hello,is this issue open to work on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers HARD
Projects
None yet
Development

No branches or pull requests

7 participants