Merge pull request nteract#1022 from lgeiger/appveyor

chore(ci): Fix windows unit tests

Author: rgbkrk

appveyor.yml

@@ -15,3 +15,4 @@ install:
 test_script:
   - node --version
   - npm --version
+  - npm test

package.json

@@ -24,7 +24,7 @@
     "test:functional:launchNewNotebook": "npm run sublaunch -- test/main/launchNewNotebook.js",
     "test:functional": "npm run test:functional:launch && npm run test:functional:launchNewNotebook",
     "test:coverage": "npm run coverage",
-    "test:unit": "cross-env NODE_PATH=app/node_modules/ mocha -r test/setup.js --compilers js:babel-core/register 'test/renderer/**/*.js'",
+    "test:unit": "cross-env NODE_PATH=app/node_modules/ mocha -r test/setup.js --compilers js:babel-core/register test/renderer/**/*.js",
     "test:unit:individual": "cross-env NODE_PATH=app/node_modules/ mocha -r test/setup.js --compilers js:babel-core/register ",
     "test:watch": "watch 'npm run test' test/",
     "test:lint": "npm run lint",

test/renderer/epics/loading-spec.js

@@ -15,44 +15,57 @@ import {
 
 import Immutable from 'immutable';
 
+const path = require('path');
+
 describe('load', () => {
-  expect(load('mytest.ipynb')).to.deep.equal({ type: 'LOAD', filename: 'mytest.ipynb' })
+  it('loads a notebook', () => {
+    expect(load('mytest.ipynb'))
+      .to.deep.equal({ type: 'LOAD', filename: 'mytest.ipynb' })
+  })
 })
 
 describe('newNotebook', () => {
-  expect(newNotebook('python3', '/tmp'))
-    .to.deep.equal({
-      type: 'NEW_NOTEBOOK',
-      kernelSpecName: 'python3',
-      cwd: '/tmp',
-    })
+  it('creates a new notebook', () => {
+    expect(newNotebook('python3', '/tmp'))
+      .to.deep.equal({
+        type: 'NEW_NOTEBOOK',
+        kernelSpecName: 'python3',
+        cwd: '/tmp',
+      })
+  })
 })
 
 describe('notebookLoaded', () => {
-  expect(notebookLoaded('test', dummyCommutable))
-    .to.deep.equal({
-      type: 'SET_NOTEBOOK',
-      filename: 'test',
-      notebook: dummyCommutable,
-    })
+  it('sets a notebook', () => {
+    expect(notebookLoaded('test', dummyCommutable))
+      .to.deep.equal({
+        type: 'SET_NOTEBOOK',
+        filename: 'test',
+        notebook: dummyCommutable,
+      })
+  })
 })
 
 describe('extractNewKernel', () => {
-  expect(extractNewKernel('/tmp/test.ipynb', dummyCommutable)).to.deep.equal({
-    type: 'LAUNCH_KERNEL',
-    kernelSpecName: 'python3',
-    cwd: '/tmp',
+  it('extracts and launches the kernel from a notebook', () => {
+    expect(extractNewKernel('/tmp/test.ipynb', dummyCommutable)).to.deep.equal({
+      type: 'LAUNCH_KERNEL',
+      kernelSpecName: 'python3',
+      cwd: path.resolve('/tmp'),
+    })
   })
 })
 
 describe('convertRawNotebook', () => {
-  const converted = convertRawNotebook({
-    filename: '/tmp/test.ipynb',
-    data: dummy,
-  });
-  expect(converted.filename).to.equal('/tmp/test.ipynb');
-
-  const notebook = converted.notebook;
-  expect(dummyCommutable.get('metadata').equals(notebook.get('metadata')))
-    .to.be.true;
+  it('converts a raw notebook', () => {
+    const converted = convertRawNotebook({
+      filename: '/tmp/test.ipynb',
+      data: dummy,
+    });
+    expect(converted.filename).to.equal('/tmp/test.ipynb');
+
+    const notebook = converted.notebook;
+    expect(dummyCommutable.get('metadata').equals(notebook.get('metadata')))
+      .to.be.true;
+  })
 })

test/renderer/native-window-spec.js

@@ -29,8 +29,13 @@ describe('tildify', () => {
     expect(nativeWindow.tildify()).to.equal('');
   });
   it('replaces the user directory with ~', () => {
-    const result = nativeWindow.tildify(path.join(remote.app.getPath('home'), 'test-notebooks'));
-    expect(result).to.have.string('~');
+    const fixture = path.join(remote.app.getPath('home'), 'test-notebooks');
+    const result = nativeWindow.tildify(fixture);
+    if (process.platform === 'win32') {
+      expect(result).to.equal(fixture);
+    } else {
+      expect(result).to.have.string('~');
+    }
   });
 });